From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42063)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1UoyOx-0003Gq-AP
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 12:05:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1UoyOw-0008Fp-28
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 12:04:59 -0400
Message-ID: <51C08509.90904@adacore.com>
Date: Tue, 18 Jun 2013 18:04:25 +0200
From: Fabien Chouteau <chouteau@adacore.com>
MIME-Version: 1.0
References: <1371567181-4917-1-git-send-email-chouteau@adacore.com>
	<107E72E3-E6CB-4EB5-B49B-EF3C4648B815@suse.de>
In-Reply-To: <107E72E3-E6CB-4EB5-B49B-EF3C4648B815@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] PPC: Add dump_mmu() for 6xx
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org

On 06/18/2013 05:31 PM, Alexander Graf wrote:
>> +    for (type = 0; type < 2; type++)
> 
> You need braces on these. Please run your patch through checkpatch.pl :).

I did ;)

-> ./scripts/checkpatch.pl 0001-PPC-Add-dump_mmu-for-6xx.patch
total: 0 errors, 0 warnings, 51 lines checked

0001-PPC-Add-dump_mmu-for-6xx.patch has no obvious style problems and is ready for submission.

> 
>> +        for (way = 0; way < env->nb_ways; way++)
>> +            for (entry = env->nb_tlb * type + env->tlb_per_way * way;
>> +                 entry < (env->nb_tlb * type + env->tlb_per_way * (way + 1));
>> +                 entry++) {
>> +
>> +                tlb = &env->tlb.tlb6[entry];
>> +                cpu_fprintf(f, "TLB %02d/%02d %s way:%d %s ["
>> +                            TARGET_FMT_lx " " TARGET_FMT_lx "]\n",
>> +                            entry % env->nb_tlb, env->nb_tlb,
>> +                            type ? "code" : "data", way,
>> +                            pte_is_valid(tlb->pte0) ? "valid" : "inval",
>> +                            tlb->EPN, tlb->EPN + TARGET_PAGE_SIZE);
>> +            }
> 
> I thought 6xx and 74xx also support HTAB and SRs? Shouldn't we dump those as well?
> 

I don't know what that is, can you send me an example of what the printf line should be?

Thanks for the review,

-- 
Fabien Chouteau