From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from service87.mimecast.com ([91.220.42.44]:43514 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932426Ab3FRQLX convert rfc822-to-8bit (ORCPT ); Tue, 18 Jun 2013 12:11:23 -0400 Message-ID: <51C086A8.3070601@arm.com> Date: Tue, 18 Jun 2013 17:11:20 +0100 From: Marc Zyngier MIME-Version: 1.0 To: Guenter Roeck CC: Viresh Kumar , "wim@iguana.be" , "linux-watchdog@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH V3 01/14] watchdog/mpcore_wdt: Mark it as BROKEN References: <22d22fe6eea294c5132e47b8901e094d60b0e99d.1371535242.git.viresh.kumar@linaro.org> <20130618154236.GA9022@roeck-us.net> In-Reply-To: <20130618154236.GA9022@roeck-us.net> Content-Type: text/plain; charset=WINDOWS-1252 Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Content-Transfer-Encoding: quoted-printable On 18/06/13 16:42, Guenter Roeck wrote: > On Tue, Jun 18, 2013 at 08:50:25PM +0530, Viresh Kumar wrote: >> This driver was broken since ever. >> >> - Interrupt request doesn't use the right API: The TWD watchdog uses a= per-cpu >> interrupt (usually interrupt #30), and the GIC configuration should = flag it as >> such. With this setup, request_irq() should fail, and the right API = is >> request_percpu_irq(), together with enable_percpu_irq()/disable_perc= pu_irq(). >> >> - Nothing ensures the userspace ioctl() will end-up kicking the watchd= og on the >> right CPU. >> >> Was last discussed here: >> >> http://lists.infradead.org/pipermail/linux-arm-kernel/2012-April/09596= 0.html >> >> Lets mark it broken until somebody with this hardware gets up and fixe= s it. >> > I must be missing something. What is the point of the remaining patches= in this > case ? Indeed. This looks like pointless churn to me, unless someone actually picks up the driver and fixes it for good. If nobody cares enough about it, then maybe it should be moved into staging and eventually retired... M. --=20 Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Tue, 18 Jun 2013 17:11:20 +0100 Subject: [PATCH V3 01/14] watchdog/mpcore_wdt: Mark it as BROKEN In-Reply-To: <20130618154236.GA9022@roeck-us.net> References: <22d22fe6eea294c5132e47b8901e094d60b0e99d.1371535242.git.viresh.kumar@linaro.org> <20130618154236.GA9022@roeck-us.net> Message-ID: <51C086A8.3070601@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 18/06/13 16:42, Guenter Roeck wrote: > On Tue, Jun 18, 2013 at 08:50:25PM +0530, Viresh Kumar wrote: >> This driver was broken since ever. >> >> - Interrupt request doesn't use the right API: The TWD watchdog uses a per-cpu >> interrupt (usually interrupt #30), and the GIC configuration should flag it as >> such. With this setup, request_irq() should fail, and the right API is >> request_percpu_irq(), together with enable_percpu_irq()/disable_percpu_irq(). >> >> - Nothing ensures the userspace ioctl() will end-up kicking the watchdog on the >> right CPU. >> >> Was last discussed here: >> >> http://lists.infradead.org/pipermail/linux-arm-kernel/2012-April/095960.html >> >> Lets mark it broken until somebody with this hardware gets up and fixes it. >> > I must be missing something. What is the point of the remaining patches in this > case ? Indeed. This looks like pointless churn to me, unless someone actually picks up the driver and fixes it for good. If nobody cares enough about it, then maybe it should be moved into staging and eventually retired... M. -- Jazz is not dead. It just smells funny...