From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55494)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Uoz8j-0000Uy-M3
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 12:52:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Uoz8f-0007fg-Ef
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 12:52:17 -0400
Message-ID: <51C0903A.2060508@suse.de>
Date: Tue, 18 Jun 2013 18:52:10 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1371398269-6213-1-git-send-email-afaerber@suse.de>
	<1371398269-6213-20-git-send-email-afaerber@suse.de>
	<CAAu8pHtDFt74=qU6TMVzrSgrKZSz7B_vdB-0mZria1G37wx+Bg@mail.gmail.com>
In-Reply-To: <CAAu8pHtDFt74=qU6TMVzrSgrKZSz7B_vdB-0mZria1G37wx+Bg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-cpu v2 19/29] cpu: Replace
 cpu_single_env with CPUState cpu_single_cpu
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>, Paul Brook <paul@codesourcery.com>, Scott Wood <scottwood@freescale.com>, qemu-ppc <qemu-ppc@nongnu.org>, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>

Am 16.06.2013 22:49, schrieb Blue Swirl:
> On Sun, Jun 16, 2013 at 3:57 PM, Andreas F=C3=A4rber <afaerber@suse.de>=
 wrote:
>> Move it to qom/cpu.h.
>=20
> While renaming, perhaps a more descriptive name could be used instead
> of 'cpu_single_cpu', something like cpu_loop_current_cpu?

There were some local variables named cpu_single_cpu (blame me :)) that
this way simply fall away, but I can certainly rename it, adding just a
few lines to the patch.

However, cpu_loop_current_cpu seems to codify that we have a sequential
loop of vCPUs, which Xen and IIUC KVM do not have and occasionally
people have looked into changing for TCG.

current_cpu is already used in a few places:

include/sysemu/kvm.h:int kvm_arch_insert_sw_breakpoint(CPUState
*current_cpu,
include/sysemu/kvm.h:int kvm_arch_remove_sw_breakpoint(CPUState
*current_cpu,
kvm-all.c:    CPUState *current_cpu =3D ENV_GET_CPU(current_env);
kvm-all.c:        bp =3D kvm_find_sw_breakpoint(current_cpu, addr);
kvm-all.c:        err =3D kvm_arch_insert_sw_breakpoint(current_cpu, bp);
kvm-all.c:
QTAILQ_INSERT_HEAD(&current_cpu->kvm_state->kvm_sw_breakpoints,
kvm-all.c:    CPUState *current_cpu =3D ENV_GET_CPU(current_env);
kvm-all.c:        bp =3D kvm_find_sw_breakpoint(current_cpu, addr);
kvm-all.c:        err =3D kvm_arch_remove_sw_breakpoint(current_cpu, bp);
kvm-all.c:
QTAILQ_REMOVE(&current_cpu->kvm_state->kvm_sw_breakpoints, bp, entry);
kvm-all.c:    CPUState *current_cpu =3D ENV_GET_CPU(current_env);
kvm-all.c:    KVMState *s =3D current_cpu->kvm_state;
kvm-all.c:        if (kvm_arch_remove_sw_breakpoint(current_cpu, bp) !=3D=
 0) {

but we could probably ignore these variable shadowings.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg