All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Holler <holler@ahsoftware.de>
To: rtc-linux@googlegroups.com
Cc: Jingoo Han <jg1.han@samsung.com>,
	linux-kernel@vger.kernel.org,
	"'Andrew Morton'" <akpm@linux-foundation.org>,
	"'John Stultz'" <john.stultz@linaro.org>,
	Sachin Kamat <sachin.kamat@linaro.org>,
	"'Dmitry Torokhov'" <dmitry.torokhov@gmail.com>
Subject: Re: [rtc-linux] Re: BUG: rtc: rtc_device_unregister() broken in 3.10-rcN
Date: Tue, 18 Jun 2013 20:22:24 +0200	[thread overview]
Message-ID: <51C0A560.2020702@ahsoftware.de> (raw)
In-Reply-To: <002901ce6bc7$71d32510$55796f30$@samsung.com>

Am 18.06.2013 03:59, schrieb Jingoo Han:
> On Tuesday, June 18, 2013 12:40 AM, Alexander Holler wrote:
>> Am 14.06.2013 19:19, schrieb Alexander Holler:
>>> Hello,
>>>
>>> I've just tested some things with 3.10-rc5+ and discovered that
>>> rtc_device_unregister is broken. This is most likely because of the
>>> switch to devm*. As 3.10 is already at -rc5, I'm posting this without
>
> CC'ed Dmitry Torokhov, Sachin Kamat
>
>
> Hi Alexander,
>
> You are using 'drivers/rtc/rtc-hid-sensor-time.c', right?
> If so, would you revert '479243b rtc: hid-sensor-time: use devm_rtc_device_register()',
> and give the result?
>
>
> Hi Dmitry, Sachin,
> You can see the kernel debug message, when the problem happens.
> (http://lists-archives.com/linux-kernel/27855385-bug-rtc-rtc_unregister_device-broken-in-3-10-rcn.html)
>

I've found the problem. Somehow I managed it with a patch i posted 
recently (3/9) to get the rtc_device_unregister() back into the 
remove-function of rtc-hid-sensor-time. Might be happend when rebasing 
the patch from 3.9.x to 3.10 or similiar, I don't know or remember.

I haven't seen it, because the backtrace doesn't show it. So what 
happend was likely:

remove -> rtc_device_unregister() (ok)
device remove -> devm -> rtc_device_unregister() (again) -> Crash.

Sorry for the noise.

Regards,

Alexander Holler

      reply	other threads:[~2013-06-18 18:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14 17:19 BUG: rtc: rtc_unregister_device() broken in 3.10-rcN Alexander Holler
2013-06-17 15:40 ` BUG: rtc: rtc_device_unregister() " Alexander Holler
2013-06-18  1:59   ` Jingoo Han
2013-06-18 18:22     ` Alexander Holler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C0A560.2020702@ahsoftware.de \
    --to=holler@ahsoftware.de \
    --cc=akpm@linux-foundation.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jg1.han@samsung.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.