All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] omap: cm_t35: Fix cm_t35 for weak splash_screen_prepare
Date: Wed, 19 Jun 2013 08:38:45 +0300	[thread overview]
Message-ID: <51C143E5.6070206@compulab.co.il> (raw)
In-Reply-To: <CAMDMJ5Ns-j_tVa2mxdddxqNpdmSYPah931kRnzg7Hc-SF4qrxw@mail.gmail.com>

On 06/18/13 19:28, Robert Winkler wrote:
> I figured this one was so simple it didn't warrant anything more than
> what's already in the subject line.

Yes, that's understood.
There are plenty of simple patches, but still it is a good practice
to have even a minimal commit message.

> 
> On Mon, Jun 17, 2013 at 11:26 PM, Igor Grinberg <grinberg@compulab.co.il> wrote:
>>
>> On 06/17/13 21:31, Robert Winkler wrote:
>>> Signed-off-by: Robert Winkler <robert.winkler@boundarydevices.com>
>>
>> Usually, we add something to the commit message, otherwise
>> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
>>
>>> ---
>>>  board/compulab/cm_t35/cm_t35.c | 2 +-
>>>  include/configs/cm_t35.h       | 1 -
>>>  2 files changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/board/compulab/cm_t35/cm_t35.c b/board/compulab/cm_t35/cm_t35.c
>>> index b0b80e5..95098af 100644
>>> --- a/board/compulab/cm_t35/cm_t35.c
>>> +++ b/board/compulab/cm_t35/cm_t35.c
>>> @@ -120,7 +120,7 @@ static inline int splash_load_from_nand(void)
>>>  }
>>>  #endif /* CONFIG_CMD_NAND */
>>>
>>> -int board_splash_screen_prepare(void)
>>> +int splash_screen_prepare(void)
>>>  {
>>>       char *env_splashimage_value;
>>>       u32 bmp_load_addr;
>>> diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h
>>> index c6e357a..b258da9 100644
>>> --- a/include/configs/cm_t35.h
>>> +++ b/include/configs/cm_t35.h
>>> @@ -339,6 +339,5 @@
>>>  #define CONFIG_SPLASH_SCREEN
>>>  #define CONFIG_CMD_BMP
>>>  #define CONFIG_BMP_16BPP
>>> -#define CONFIG_SPLASH_SCREEN_PREPARE
>>>
>>>  #endif /* __CONFIG_H */
>>>
>>
>> --
>> Regards,
>> Igor.
> 

-- 
Regards,
Igor.

  reply	other threads:[~2013-06-19  5:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17 18:31 [U-Boot] [PATCH 0/3 v2] video: lcd: splash screen prepare changes Robert Winkler
2013-06-17 18:31 ` [U-Boot] [PATCH 1/3 v2] video: lcd: Add CONFIG_SPLASH_SCREEN_PREPARE support to CONFIG_VIDEO Robert Winkler
2013-06-18  6:23   ` Igor Grinberg
2013-06-17 18:31 ` [U-Boot] [PATCH 2/3] video: lcd: Make splash_screen_prepare weak, remove config macro Robert Winkler
2013-06-18  6:24   ` Igor Grinberg
2013-06-17 18:31 ` [U-Boot] [PATCH 3/3] omap: cm_t35: Fix cm_t35 for weak splash_screen_prepare Robert Winkler
2013-06-18  6:26   ` Igor Grinberg
2013-06-18 16:28     ` Robert Winkler
2013-06-19  5:38       ` Igor Grinberg [this message]
2013-06-26 23:00 ` [U-Boot] [PATCH 0/3 v2] video: lcd: splash screen prepare changes Robert Winkler
2013-07-01 19:57   ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C143E5.6070206@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.