From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UpD3v-00077B-Pw for mharc-qemu-trivial@gnu.org; Wed, 19 Jun 2013 03:44:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpD3t-00073B-U7 for qemu-trivial@nongnu.org; Wed, 19 Jun 2013 03:44:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpD3s-0008Uo-Tw for qemu-trivial@nongnu.org; Wed, 19 Jun 2013 03:44:13 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:34629) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpD3p-0008U1-3R; Wed, 19 Jun 2013 03:44:09 -0400 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id A8B3141974; Wed, 19 Jun 2013 11:44:07 +0400 (MSK) Message-ID: <51C16146.3040100@msgid.tls.msk.ru> Date: Wed, 19 Jun 2013 11:44:06 +0400 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/17.0 Icedove/17.0 MIME-Version: 1.0 To: Markus Armbruster References: <1371542723-926-1-git-send-email-armbru@redhat.com> In-Reply-To: <1371542723-926-1-git-send-email-armbru@redhat.com> X-Enigmail-Version: 1.5.1 OpenPGP: id=804465C5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, berrange@redhat.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org Subject: Re: [Qemu-trivial] [PATCH] acl: acl_add can't insert before last list element, fix X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jun 2013 07:44:15 -0000 18.06.2013 12:05, Markus Armbruster wrote: [] > The second acl_add inserts at position 2 instead of 1. > > Root cause is an off-by-one in qemu_acl_insert(): when index == > acl->nentries, it appends instead of inserting before the last list > element. Thanks, applied to the trivial patches queue. /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpD3q-000707-3q for qemu-devel@nongnu.org; Wed, 19 Jun 2013 03:44:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpD3p-0008U7-Am for qemu-devel@nongnu.org; Wed, 19 Jun 2013 03:44:10 -0400 Message-ID: <51C16146.3040100@msgid.tls.msk.ru> Date: Wed, 19 Jun 2013 11:44:06 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1371542723-926-1-git-send-email-armbru@redhat.com> In-Reply-To: <1371542723-926-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] acl: acl_add can't insert before last list element, fix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, qemu-stable@nongnu.org 18.06.2013 12:05, Markus Armbruster wrote: [] > The second acl_add inserts at position 2 instead of 1. > > Root cause is an off-by-one in qemu_acl_insert(): when index == > acl->nentries, it appends instead of inserting before the last list > element. Thanks, applied to the trivial patches queue. /mjt