From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: pygrub patch to allow explicit offset to fs Date: Wed, 19 Jun 2013 11:06:25 +0100 Message-ID: <51C182A1.10007@eu.citrix.com> References: <51C0EFE5.10109@redpill-linpro.com> <1371629850.22783.58.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1371629850.22783.58.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Kjetil Torgrim Homme , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 19/06/13 09:17, Ian Campbell wrote: > On Wed, 2013-06-19 at 01:40 +0200, Kjetil Torgrim Homme wrote: >> I recently needed an old VM to work even though it was created on a SAN >> LUN with no partition table, just LVM straight onto the raw device. >> >> pygrub didn't like this, so I added a simple hack to allow the user to >> override pygrub's probing when necessary. please consider applying this >> patch. btw, I think most LVM will have first filesystem at offset 196608. >> >> >> commit 80a3f7b48da235695f8560deb41c19b23e7799e3 >> Author: Kjetil Torgrim Homme >> Date: Wed Jun 19 00:54:43 2013 +0200 >> >> allow user to specify offset parameter which overrides partition >> table parsing >> >> Signed-off-by: Kjetil Torgrim Homme > Looks good to me, thanks. > > Acked-by: Ian Campbell > > although I've suggested a possible simplification below. > > I think with the freeze being in force this, as a new feature, will have > to wait for the 4.4 dev cycle to be applied, although I will defer to > George's judgement. Yeah, I think this will have to wait. It does also touch a codepath used by people not using this feature, and so there is ever so slight a chance that there will be breakage. -George