From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/7] gpio: davinci: coding style correction
Date: Wed, 19 Jun 2013 16:22:21 +0530 [thread overview]
Message-ID: <51C18D65.6010009@ti.com> (raw)
In-Reply-To: <1371202532-14628-2-git-send-email-avinashphilip@ti.com>
On 6/14/2013 3:05 PM, Philip Avinash wrote:
> Make some minor coding style fixes. Use proper multi-line
> commenting style, arrange include files alphabetically use
> macros for bit definitions.
Its a register offset, not bit definition.
>
> Signed-off-by: Philip Avinash <avinashphilip@ti.com>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---
> Changes since v1:
> - Remove variable name replacement
> - Add line break after BINTEN macro definition
>
> drivers/gpio/gpio-davinci.c | 21 +++++++++++++--------
> 1 file changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index 17df6db..e8d189c 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -9,12 +9,12 @@
> * the Free Software Foundation; either version 2 of the License, or
> * (at your option) any later version.
> */
> -#include <linux/gpio.h>
> -#include <linux/errno.h>
> -#include <linux/kernel.h>
> +
This is unnecessary empty line. I made these fixes locally and added
this to my v3.11/gpio branch.
Thanks,
Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: Philip Avinash <avinashphilip@ti.com>
Cc: <khilman@deeprootsystems.com>, <linux@arm.linux.org.uk>,
<grant.likely@secretlab.ca>, <linus.walleij@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<davinci-linux-open-source@linux.davincidsp.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/7] gpio: davinci: coding style correction
Date: Wed, 19 Jun 2013 16:22:21 +0530 [thread overview]
Message-ID: <51C18D65.6010009@ti.com> (raw)
In-Reply-To: <1371202532-14628-2-git-send-email-avinashphilip@ti.com>
On 6/14/2013 3:05 PM, Philip Avinash wrote:
> Make some minor coding style fixes. Use proper multi-line
> commenting style, arrange include files alphabetically use
> macros for bit definitions.
Its a register offset, not bit definition.
>
> Signed-off-by: Philip Avinash <avinashphilip@ti.com>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---
> Changes since v1:
> - Remove variable name replacement
> - Add line break after BINTEN macro definition
>
> drivers/gpio/gpio-davinci.c | 21 +++++++++++++--------
> 1 file changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index 17df6db..e8d189c 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -9,12 +9,12 @@
> * the Free Software Foundation; either version 2 of the License, or
> * (at your option) any later version.
> */
> -#include <linux/gpio.h>
> -#include <linux/errno.h>
> -#include <linux/kernel.h>
> +
This is unnecessary empty line. I made these fixes locally and added
this to my v3.11/gpio branch.
Thanks,
Sekhar
next prev parent reply other threads:[~2013-06-19 10:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 9:35 [PATCH v2 0/7] Convert GPIO Davinci to platform driver Philip Avinash
2013-06-14 9:35 ` Philip Avinash
2013-06-14 9:35 ` [PATCH v2 1/7] gpio: davinci: coding style correction Philip Avinash
2013-06-14 9:35 ` Philip Avinash
2013-06-19 10:52 ` Sekhar Nori [this message]
2013-06-19 10:52 ` Sekhar Nori
2013-06-14 9:35 ` [PATCH v2 2/7] gpio: davinci: move to platform device Philip Avinash
2013-06-14 9:35 ` Philip Avinash
2013-06-19 11:23 ` Sekhar Nori
2013-06-19 11:23 ` Sekhar Nori
2013-06-14 9:35 ` [PATCH v2 3/7] ARM: davinci: da8xx: creation of gpio " Philip Avinash
2013-06-14 9:35 ` Philip Avinash
2013-06-19 11:51 ` Sekhar Nori
2013-06-19 11:51 ` Sekhar Nori
2013-06-14 9:35 ` [PATCH v2 4/7] ARM: davinci: creation of gpio platform device for dmxxx platforms Philip Avinash
2013-06-14 9:35 ` Philip Avinash
2013-06-20 6:18 ` Sekhar Nori
2013-06-20 6:18 ` Sekhar Nori
2013-06-14 9:35 ` [PATCH v2 5/7] ARM: davinci: da8xx: gpio device creation Philip Avinash
2013-06-14 9:35 ` Philip Avinash
2013-06-20 8:40 ` Sekhar Nori
2013-06-20 8:40 ` Sekhar Nori
2013-06-20 9:07 ` Sekhar Nori
2013-06-20 9:07 ` Sekhar Nori
2013-06-14 9:35 ` [PATCH v2 6/7] ARM: davinci: dmxxx: " Philip Avinash
2013-06-14 9:35 ` Philip Avinash
2013-06-20 8:55 ` Sekhar Nori
2013-06-20 8:55 ` Sekhar Nori
2013-06-14 9:35 ` [PATCH v2 7/7] ARM: davinci: Start using gpiolib API inplace of inline functions Philip Avinash
2013-06-14 9:35 ` Philip Avinash
2013-06-19 19:05 ` Linus Walleij
2013-06-19 19:05 ` Linus Walleij
2013-06-20 9:19 ` Sekhar Nori
2013-06-20 9:19 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C18D65.6010009@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.