From: "Andreas Färber" <afaerber@suse.de>
To: peter.crosthwaite@xilinx.com
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org,
edgar.iglesias@gmail.com
Subject: Re: [Qemu-devel] [PATCH v1 5/5] nand: Don't inherit from Sysbus
Date: Wed, 19 Jun 2013 13:06:18 +0200 [thread overview]
Message-ID: <51C190AA.8050608@suse.de> (raw)
In-Reply-To: <af1682cab1b1106aa58a782f758387e2a3f18bff.1371553360.git.peter.crosthwaite@xilinx.com>
Am 18.06.2013 13:12, schrieb peter.crosthwaite@xilinx.com:
> From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>
> Nand chips are not sysbus devices - they do not have any sense of MMIO,
> nor interrupts. Re-parent to TYPE_DEVICE accordingly.
>
> Cc: afaerber@suse.de
>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
>
> hw/block/nand.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
CPUs are bus-less devices and work fine so far, so
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-06-19 11:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 11:07 [Qemu-devel] [PATCH v1 0/5] Nand Cleanup peter.crosthwaite
2013-06-18 11:08 ` [Qemu-trivial] [PATCH v1 1/5] block/nand: Factor out common code peter.crosthwaite
2013-06-18 11:08 ` [Qemu-devel] " peter.crosthwaite
2013-06-19 8:09 ` [Qemu-trivial] " Michael Tokarev
2013-06-19 8:09 ` [Qemu-devel] " Michael Tokarev
2013-06-19 8:13 ` [Qemu-trivial] [Qemu-devel] " Peter Crosthwaite
2013-06-19 8:13 ` [Qemu-devel] [Qemu-trivial] " Peter Crosthwaite
2013-06-19 8:47 ` [Qemu-trivial] [Qemu-devel] " Michael Tokarev
2013-06-19 8:47 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-07-31 23:49 ` [Qemu-trivial] [Qemu-devel] " Peter Crosthwaite
2013-07-31 23:49 ` [Qemu-devel] [Qemu-trivial] " Peter Crosthwaite
2013-06-19 8:54 ` Peter Maydell
2013-06-19 8:54 ` [Qemu-devel] " Peter Maydell
2013-06-18 11:08 ` [Qemu-trivial] [PATCH v1 2/5] block/nand: Formatting sweep peter.crosthwaite
2013-06-18 11:08 ` [Qemu-devel] " peter.crosthwaite
2013-06-19 7:53 ` [Qemu-trivial] " Michael Tokarev
2013-06-19 7:53 ` [Qemu-devel] " Michael Tokarev
2013-06-18 11:10 ` [Qemu-devel] [PATCH v1 3/5] block/nand: QOM casting sweep peter.crosthwaite
2013-06-19 10:52 ` Andreas Färber
2013-06-18 11:11 ` [Qemu-devel] [PATCH v1 4/5] block/nand: Convert Sysbus::init to Device::realize peter.crosthwaite
2013-06-19 10:56 ` Andreas Färber
2013-06-18 11:12 ` [Qemu-devel] [PATCH v1 5/5] nand: Don't inherit from Sysbus peter.crosthwaite
2013-06-19 11:06 ` Andreas Färber [this message]
2013-06-25 18:16 ` [Qemu-devel] [PATCH v1 0/5] Nand Cleanup Peter Maydell
2013-06-26 0:37 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C190AA.8050608@suse.de \
--to=afaerber@suse.de \
--cc=edgar.iglesias@gmail.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.