From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Wed, 19 Jun 2013 16:50:53 +0400 Subject: [PATCH V3 09/11] USB: OHCI: Properly handle ohci-pxa27x suspend In-Reply-To: <1371643936-3314-10-git-send-email-manjunath.goudar@linaro.org> References: <1371050918-29472-1-git-send-email-manjunath.goudar@linaro.org> <1371643936-3314-1-git-send-email-manjunath.goudar@linaro.org> <1371643936-3314-10-git-send-email-manjunath.goudar@linaro.org> Message-ID: <51C1A92D.4080404@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 19-06-2013 16:12, Manjunath Goudar wrote: > Suspend scenario in case of ohci-pxa27x glue was not > properly handled as it was not suspending generic part > of ohci controller. Calling explicitly the ohci_suspend() > routine in ohci_hcd_pxa27x_drv_suspend() will ensure proper > handling of suspend scenario. > Signed-off-by: Manjunath Goudar > Cc: Arnd Bergmann > Cc: Alan Stern > Cc: Greg KH > Cc: linux-usb at vger.kernel.org > V2: > -Incase ohci_suspend() fails, return right away without > executing further. > V3: > -Aligned variable "do_wakeup" and "ret". > --- > drivers/usb/host/ohci-pxa27x.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c > index 3a9c01d..1dc2a72 100644 > --- a/drivers/usb/host/ohci-pxa27x.c > +++ b/drivers/usb/host/ohci-pxa27x.c > @@ -564,13 +564,19 @@ static int ohci_hcd_pxa27x_drv_suspend(struct device *dev) > { > struct usb_hcd *hcd = dev_get_drvdata(dev); > struct pxa27x_ohci *ohci = to_pxa27x_ohci(hcd); > + bool do_wakeup = device_may_wakeup(dev); > + int ret; And again, no variable name alignment was needed. WBR, Sergei