From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpI7e-0003KA-BE for qemu-devel@nongnu.org; Wed, 19 Jun 2013 09:08:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpI7Z-0005Zq-0u for qemu-devel@nongnu.org; Wed, 19 Jun 2013 09:08:26 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38361 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpI7Y-0005Yl-NH for qemu-devel@nongnu.org; Wed, 19 Jun 2013 09:08:20 -0400 Message-ID: <51C1AD3F.8050808@suse.de> Date: Wed, 19 Jun 2013 15:08:15 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1369709437-24969-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1369709437-24969-4-git-send-email-qiaonuohan@cn.fujitsu.com> In-Reply-To: <1369709437-24969-4-git-send-email-qiaonuohan@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 3/9] dump: Move struct definition into dump_memroy.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qiaonuohan@cn.fujitsu.com Cc: Peter Maydell , qemu-devel@nongnu.org, lcapitulino@redhat.com, zhangxh@cn.fujitsu.com, kumagai-atsushi@mxc.nes.nec.co.jp, anderson@redhat.com "dump_memory.h" Am 28.05.2013 04:50, schrieb qiaonuohan@cn.fujitsu.com: > From: Qiao Nuohan >=20 > Move definition of struct DumpState into include/sysemu/dump_memory.h. >=20 > Signed-off-by: Qiao Nuohan > Reviewed-by: Zhang Xiaohe > --- > dump.c | 22 +--------------------- > include/sysemu/dump_memory.h | 40 ++++++++++++++++++++++++++++++++++= ++++++ > 2 files changed, 41 insertions(+), 21 deletions(-) > create mode 100644 include/sysemu/dump_memory.h >=20 > diff --git a/dump.c b/dump.c > index c0d3da5..9ac66be 100644 > --- a/dump.c > +++ b/dump.c > @@ -15,10 +15,9 @@ > #include "elf.h" > #include "cpu.h" > #include "exec/cpu-all.h" > -#include "exec/hwaddr.h" > #include "monitor/monitor.h" > #include "sysemu/kvm.h" > -#include "sysemu/dump.h" > +#include "sysemu/dump_memory.h" > #include "sysemu/sysemu.h" > #include "sysemu/memory_mapping.h" > #include "qapi/error.h" > @@ -57,25 +56,6 @@ static uint64_t cpu_convert_to_target64(uint64_t val= , int endian) > return val; > } > =20 > -typedef struct DumpState { > - ArchDumpInfo dump_info; > - MemoryMappingList list; > - uint16_t phdr_num; > - uint32_t sh_info; > - bool have_section; > - bool resume; > - size_t note_size; > - hwaddr memory_offset; > - int fd; > - > - RAMBlock *block; > - ram_addr_t start; > - bool has_filter; > - int64_t begin; > - int64_t length; > - Error **errp; > -} DumpState; > - > static int dump_cleanup(DumpState *s) > { > int ret =3D 0; > diff --git a/include/sysemu/dump_memory.h b/include/sysemu/dump_memory.= h > new file mode 100644 > index 0000000..ce22c05 > --- /dev/null > +++ b/include/sysemu/dump_memory.h > @@ -0,0 +1,40 @@ > +/* > + * QEMU dump memory > + * > + * Copyright (C) 2013 FUJITSU LIMITED > + * > + * Authors: > + * Qiao Nuohan I wondered whether you may want to keep Wen Congyang here as original dump.c author and the corresponding dump.c copyright - but since it's all Fujitsu that's none of my business. ;) Regards, Andreas > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or = later. > + * See the COPYING file in the top-level directory. > + * > + */ > + > +#ifndef DUMP_MEMORY_H > +#define DUMP_MEMORY_H > + > +#include "exec/cpu-all.h" > +#include "sysemu/memory_mapping.h" > +#include "sysemu/dump.h" > + > +typedef struct DumpState { > + ArchDumpInfo dump_info; > + MemoryMappingList list; > + uint16_t phdr_num; > + uint32_t sh_info; > + bool have_section; > + bool resume; > + size_t note_size; > + hwaddr memory_offset; > + int fd; > + > + RAMBlock *block; > + ram_addr_t start; > + bool has_filter; > + int64_t begin; > + int64_t length; > + Error **errp; > +} DumpState; > + > +#endif >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg