From: Michael Tokarev <mjt@tls.msk.ru>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
Stefan Weil <sw@weilnetz.de>, qemu-devel <qemu-devel@nongnu.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] pseries: Fix compiler warning (conversion of pointer to integral value)
Date: Thu, 20 Jun 2013 09:10:08 +0400 [thread overview]
Message-ID: <51C28EB0.3040508@msgid.tls.msk.ru> (raw)
In-Reply-To: <44C4E791-957F-4B61-BE3D-DDB1E3F2238D@suse.de>
20.06.2013 01:40, Alexander Graf wrote:
>
> On 19.06.2013, at 23:08, Stefan Weil wrote:
>
>> This kind of type cast must use uintptr_t or target_ulong to be portable
>> for hosts with sizeof(void *) != sizeof(long).
>>
>> Here the value is assigned to a variable of type target_ulong.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>
> Acked-by: Alexander Graf <agraf@suse.de>
>
> I suppose this one goes through the trivial tree?
Anything which goes to -trivial can be applied directly or
into some other subsystem tree first. When I send a pull
request I rebase trivial tree ontop of current master and
filter out anything which has been already applied, so that's
not an issue. The only possible issue is when you applied
it to some other tree, and -trivial pull request were handled
before that other tree - how that will be handled by git?
Will it complain (so that the situation should be resolved
manually), will it apply nothing or will it appy an empty
patch? (the patch signature will be different, with
different S-o-b.) I think I've seen empty commits before
in qemu tree, with the same subject/author as some previous
commit.
Thanks,
/mjt
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
Stefan Weil <sw@weilnetz.de>, qemu-devel <qemu-devel@nongnu.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH] pseries: Fix compiler warning (conversion of pointer to integral value)
Date: Thu, 20 Jun 2013 09:10:08 +0400 [thread overview]
Message-ID: <51C28EB0.3040508@msgid.tls.msk.ru> (raw)
In-Reply-To: <44C4E791-957F-4B61-BE3D-DDB1E3F2238D@suse.de>
20.06.2013 01:40, Alexander Graf wrote:
>
> On 19.06.2013, at 23:08, Stefan Weil wrote:
>
>> This kind of type cast must use uintptr_t or target_ulong to be portable
>> for hosts with sizeof(void *) != sizeof(long).
>>
>> Here the value is assigned to a variable of type target_ulong.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>
> Acked-by: Alexander Graf <agraf@suse.de>
>
> I suppose this one goes through the trivial tree?
Anything which goes to -trivial can be applied directly or
into some other subsystem tree first. When I send a pull
request I rebase trivial tree ontop of current master and
filter out anything which has been already applied, so that's
not an issue. The only possible issue is when you applied
it to some other tree, and -trivial pull request were handled
before that other tree - how that will be handled by git?
Will it complain (so that the situation should be resolved
manually), will it apply nothing or will it appy an empty
patch? (the patch signature will be different, with
different S-o-b.) I think I've seen empty commits before
in qemu tree, with the same subject/author as some previous
commit.
Thanks,
/mjt
next prev parent reply other threads:[~2013-06-20 5:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 21:08 [Qemu-trivial] [PATCH] pseries: Fix compiler warning (conversion of pointer to integral value) Stefan Weil
2013-06-19 21:08 ` [Qemu-devel] " Stefan Weil
2013-06-19 21:40 ` [Qemu-trivial] " Alexander Graf
2013-06-19 21:40 ` [Qemu-devel] " Alexander Graf
2013-06-20 4:40 ` [Qemu-trivial] " Stefan Weil
2013-06-20 4:40 ` [Qemu-devel] " Stefan Weil
2013-06-20 5:10 ` Michael Tokarev [this message]
2013-06-20 5:10 ` Michael Tokarev
2013-06-20 5:33 ` [Qemu-devel] deadlock while running graphics application on QEMU Mirza, Taimoor
2013-06-20 8:48 ` [Qemu-trivial] [Qemu-devel] [PATCH] pseries: Fix compiler warning (conversion of pointer to integral value) Alexander Graf
2013-06-20 8:48 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C28EB0.3040508@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.