All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>,
	qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Ping Fan Liu <pingfank@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [RFC 06/13] qemu-thread: add TLS wrappers
Date: Thu, 20 Jun 2013 10:50:32 +0200	[thread overview]
Message-ID: <51C2C258.1050003@redhat.com> (raw)
In-Reply-To: <20130620072633.GA24927@localhost.nay.redhat.com>

Il 20/06/2013 09:26, Fam Zheng ha scritto:
> On Fri, 06/14 11:48, Stefan Hajnoczi wrote:
>> From: Paolo Bonzini <pbonzini@redhat.com>
>>
>> Fast TLS is not available on some platforms, but it is always nice to
>> use it.  This wrapper implementation falls back to pthread_get/setspecific
>> on POSIX systems that lack __thread, but uses the dynamic linker's TLS
>> support on Linux and Windows.
>>
>> The user shall call alloc_foo() in every thread that needs to access the
>> variable---exactly once and before any access.  foo is the name of the
>> variable as passed to DECLARE_TLS and DEFINE_TLS.  Then, get_foo() will
>> return the address of the variable.  It is guaranteed to remain the same
>> across the lifetime of a thread, so you can cache it.
> 
> Would tls_alloc_foo() and tls_get_foo() be easier to read and less
> possible for name conflict?

Fine by me.

Paolo

  reply	other threads:[~2013-06-20  8:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14  9:48 [Qemu-devel] [RFC 00/13] dataplane: use block layer Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 01/13] block: fix bdrv_flush() ordering in bdrv_close() Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 02/13] dataplane: sync virtio.c and vring.c virtqueue state Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 03/13] block: add BlockDevOps->drain_threads_cb() Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 04/13] virtio-blk: implement BlockDevOps->drain_threads_cb() Stefan Hajnoczi
2013-06-14 14:23   ` Paolo Bonzini
2013-06-14  9:48 ` [Qemu-devel] [RFC 05/13] exec: do not use qemu/tls.h Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 06/13] qemu-thread: add TLS wrappers Stefan Hajnoczi
2013-06-20  7:26   ` Fam Zheng
2013-06-20  8:50     ` Paolo Bonzini [this message]
2013-06-20 12:54       ` Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 07/13] block: add thread_aio_context TLS variable Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 08/13] block: drop bdrv_get_aio_context() Stefan Hajnoczi
2013-06-14 14:12   ` Paolo Bonzini
2013-06-17 14:57     ` Stefan Hajnoczi
2013-06-17 15:03       ` Paolo Bonzini
2013-06-18  9:29         ` Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 09/13] main-loop: use thread-local AioContext Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 10/13] block: disable I/O throttling outside main loop Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 11/13] dataplane: use block layer for I/O Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 12/13] dataplane: drop ioq Linux AIO request queue Stefan Hajnoczi
2013-06-14  9:48 ` [Qemu-devel] [RFC 13/13] block: drop raw_get_aio_fd() Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C2C258.1050003@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=pingfank@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.