Re: [PATCH v2 2/5] hvmloader: Load large devices into high MMIO space as needed

[George Dunlap <george.dunlap@eu.citrix.com>]

On 19/06/13 18:18, Stefano Stabellini wrote:
> On Tue, 18 Jun 2013, George Dunlap wrote:
>> Keep track of how much mmio space is left total, as well as the amount
>> of "low" MMIO space (<4GiB), and only load devices into high memory
>> if there is not enough low memory for the rest of the devices to fit.
>>
>> Because devices are processed by size in order from large to small,
>> this should preferentially relocate devices with large BARs to 64-bit
>> space.
>>
>> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>> CC: Ian Jackson <ian.jackson@citrix.com>
>> CC: Ian Campbell <ian.campbell@citrix.com>
>> CC: Stefano Stabellini <stefano.stabellini@citrix.com>
>> CC: Hanweidong <hanweidong@huawei.com>
>> ---
>>   tools/firmware/hvmloader/pci.c |   12 ++++++++++--
>>   1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/firmware/hvmloader/pci.c b/tools/firmware/hvmloader/pci.c
>> index 8691a19..7f306a1 100644
>> --- a/tools/firmware/hvmloader/pci.c
>> +++ b/tools/firmware/hvmloader/pci.c
>> @@ -38,7 +38,8 @@ void pci_setup(void)
>>   {
>>       uint8_t is_64bar, using_64bar, bar64_relocate = 0;
>>       uint32_t devfn, bar_reg, cmd, bar_data, bar_data_upper;
>> -    uint64_t base, bar_sz, bar_sz_upper, low_mmio_left, mmio_total = 0;
>> +    uint64_t base, bar_sz, bar_sz_upper, low_mmio_left, mmio_total = 0,
>> +        mmio_left;
> It think you can just use mmio_total instead of reintroducing mmio_left

Ack.

  -George