From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhao Hongjiang Date: Thu, 20 Jun 2013 18:59:51 +0800 Subject: [Cluster-devel] [PATCH] dlm: config: using strlcpy instead of strncpy Message-ID: <51C2E0A7.5000602@huawei.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit for NUL terminated string, need alway set '\0' in the end. Signed-off-by: Zhao Hongjiang --- fs/dlm/config.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/dlm/config.c b/fs/dlm/config.c index 7d58d5b..76feb4b 100644 --- a/fs/dlm/config.c +++ b/fs/dlm/config.c @@ -138,8 +138,9 @@ static ssize_t cluster_cluster_name_read(struct dlm_cluster *cl, char *buf) static ssize_t cluster_cluster_name_write(struct dlm_cluster *cl, const char *buf, size_t len) { - strncpy(dlm_config.ci_cluster_name, buf, DLM_LOCKSPACE_LEN); - strncpy(cl->cl_cluster_name, buf, DLM_LOCKSPACE_LEN); + strlcpy(dlm_config.ci_cluster_name, buf, + sizeof(dlm_config.ci_cluster_name)); + strlcpy(cl->cl_cluster_name, buf, sizeof(cl->cl_cluster_name)); return len; } -- 1.7.1