From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Date: Thu, 20 Jun 2013 12:44:26 +0000 Subject: Re: [PATCH v7 0/3] SH pinctrl DT support Message-Id: <51C2F92A.5050101@imgtec.com> List-Id: References: <1371495003-11185-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <51C01FAF.8050006@imgtec.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Linus Walleij Cc: Laurent Pinchart , =?ISO-8859-1?Q?Heiko_St=FCbner?= , "linux-sh@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , Magnus Damm , Simon Horman On 18/06/13 10:05, Linus Walleij wrote: > On Tue, Jun 18, 2013 at 10:51 AM, James Hogan wrote: > >> Should we be standardizing the pins/groups/function properties too, >> since the strings are pretty much passed straight through? The usage >> seems pretty similar between the drivers I've seen (except ugly vendor >> prefixes), so we could presumably get away with a single implementation >> of dt_node_to_map? > > This is an orthogonal issue I'd say. agreed. > Basically this goes back to the quite prolonged discussion about > device tree bindings and the fact that we added the > .dt_node_to_map() and .dt_free_map() functions in the > first place. > > I'd be happy to consolidate these mapping functions where > possible, by moving to the core, basically. > > But that would be a separate patch series.... interested? ;-) Mildly, but I can't guarantee I'll get the time. Cheers James From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [PATCH v7 0/3] SH pinctrl DT support Date: Thu, 20 Jun 2013 13:44:26 +0100 Message-ID: <51C2F92A.5050101@imgtec.com> References: <1371495003-11185-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <51C01FAF.8050006@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-sh-owner@vger.kernel.org To: Linus Walleij Cc: Laurent Pinchart , =?ISO-8859-1?Q?Heiko_St=FCbner?= , "linux-sh@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , Magnus Damm , Simon Horman List-Id: devicetree@vger.kernel.org On 18/06/13 10:05, Linus Walleij wrote: > On Tue, Jun 18, 2013 at 10:51 AM, James Hogan wrote: > >> Should we be standardizing the pins/groups/function properties too, >> since the strings are pretty much passed straight through? The usage >> seems pretty similar between the drivers I've seen (except ugly vendor >> prefixes), so we could presumably get away with a single implementation >> of dt_node_to_map? > > This is an orthogonal issue I'd say. agreed. > Basically this goes back to the quite prolonged discussion about > device tree bindings and the fact that we added the > .dt_node_to_map() and .dt_free_map() functions in the > first place. > > I'd be happy to consolidate these mapping functions where > possible, by moving to the core, basically. > > But that would be a separate patch series.... interested? ;-) Mildly, but I can't guarantee I'll get the time. Cheers James