All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: Yuvaraj Kumar C D <yuvaraj.cd@gmail.com>
Cc: linux-mmc@vger.kernel.org, cjb@laptop.org,
	jh80.chung@samsung.com, tgih.jun@samsung.com,
	thomas.ab@samsung.com, Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>,
	Abhilash Kesavan <a.kesavan@samsung.com>
Subject: Re: [PATCH 1/2] mmc: dw_mmc: exynos: Add a new compatible string for exynos5420
Date: Thu, 20 Jun 2013 21:50:51 +0900	[thread overview]
Message-ID: <51C2FAAB.1050708@samsung.com> (raw)
In-Reply-To: <1369389873-15018-2-git-send-email-yuvaraj.cd@samsung.com>

Looks good to me.

Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

On 05/24/2013 07:04 PM, Yuvaraj Kumar C D wrote:
> The Exynos5420 has a DWMMC controller which is different from prior
> versions.This patch adds a new compatible string for Exynos5420.
> 
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
> ---
>  drivers/mmc/host/dw_mmc-exynos.c |    9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index f013e7e..f883b17 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -41,6 +41,7 @@ enum dw_mci_exynos_type {
>  	DW_MCI_TYPE_EXYNOS4210,
>  	DW_MCI_TYPE_EXYNOS4412,
>  	DW_MCI_TYPE_EXYNOS5250,
> +	DW_MCI_TYPE_EXYNOS5420,
>  };
>  
>  /* Exynos implementation specific driver private data */
> @@ -64,6 +65,9 @@ static struct dw_mci_exynos_compatible {
>  	}, {
>  		.compatible	= "samsung,exynos5250-dw-mshc",
>  		.ctrl_type	= DW_MCI_TYPE_EXYNOS5250,
> +	}, {
> +		.compatible	= "samsung,exynos5420-dw-mshc",
> +		.ctrl_type	= DW_MCI_TYPE_EXYNOS5420,
>  	},
>  };
>  
> @@ -92,7 +96,8 @@ static int dw_mci_exynos_setup_clock(struct dw_mci *host)
>  {
>  	struct dw_mci_exynos_priv_data *priv = host->priv;
>  
> -	if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS5250)
> +	if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS5250 ||
> +		priv->ctrl_type == DW_MCI_TYPE_EXYNOS5420)
>  		host->bus_hz /= (priv->ciu_div + 1);
>  	else if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS4412)
>  		host->bus_hz /= EXYNOS4412_FIXED_CIU_CLK_DIV;
> @@ -175,6 +180,8 @@ static const struct of_device_id dw_mci_exynos_match[] = {
>  			.data = &exynos_drv_data, },
>  	{ .compatible = "samsung,exynos5250-dw-mshc",
>  			.data = &exynos_drv_data, },
> +	{ .compatible = "samsung,exynos5420-dw-mshc",
> +			.data = &exynos_drv_data, },
>  	{},
>  };
>  MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
> 


  reply	other threads:[~2013-06-20 12:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-24 10:04 [PATCH 0/2] mmc:dw_mmc: Enable dw_mmc support for Exynos5420 Yuvaraj Kumar C D
2013-05-24 10:04 ` [PATCH 1/2] mmc: dw_mmc: exynos: Add a new compatible string for exynos5420 Yuvaraj Kumar C D
2013-06-20 12:50   ` Jaehoon Chung [this message]
2013-08-14  9:27     ` Yuvaraj Kumar
2013-08-25  4:22   ` Chris Ball
2013-05-24 10:04 ` [PATCH 2/2] mmc: dw_mmc: add a quirk for Security Management Unit Yuvaraj Kumar C D
2013-06-20 13:02   ` Jaehoon Chung
2013-06-21 23:48   ` Doug Anderson
2013-06-24  3:29   ` Seungwon Jeon
2013-06-27 11:50     ` Yuvaraj Kumar
2013-06-28  2:15       ` Seungwon Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C2FAAB.1050708@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=a.kesavan@samsung.com \
    --cc=cjb@laptop.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=tgih.jun@samsung.com \
    --cc=thomas.ab@samsung.com \
    --cc=yuvaraj.cd@gmail.com \
    --cc=yuvaraj.cd@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.