From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH 7/7] xen: Implement hot_add_cpu hook.
Date: Thu, 20 Jun 2013 14:19:34 +0100
Message-ID: <51C30166.5090307@citrix.com>
References: <1371478402-28082-1-git-send-email-anthony.perard@citrix.com>
	<1371478549-28527-1-git-send-email-anthony.perard@citrix.com>
	<1371478549-28527-7-git-send-email-anthony.perard@citrix.com>
	<alpine.DEB.2.02.1306201215260.4548@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1306201215260.4548@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@citrix.com>, Xen Devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 20/06/13 12:21, Stefano Stabellini wrote:
> Can't we just call pc_new_cpu and cpu_x86_create like upstream QEMU
> does?
> Are there any reasons why we can't introduce the same
> cpu_added_notifier that is upstream?

Yes, in our current version of qemu-xen, a CPU can not be hotplug.

When pc_new_cpu is called, there is a check to see if this object (cpu)
can be hotplug to the machine. The original patch series was introducing
that, I think. So it would require few more patches from QEMU which
would made the backport more complicated.

And the notifier depend on the creation of new object cpu.

-- 
Anthony PERARD