From: Mike Christie <michaelc@cs.wisc.edu>
To: open-iscsi@googlegroups.com
Cc: Eddie Wai <eddie.wai@broadcom.com>,
James Bottomley <jbottomley@parallels.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Michael Chan <mchan@broadcom.com>
Subject: Re: [PATCH] LIBISCSI: Added new boot entries in the session sysfs
Date: Thu, 20 Jun 2013 10:57:02 -0500 [thread overview]
Message-ID: <51C3264E.7080802@cs.wisc.edu> (raw)
In-Reply-To: <1370889281-22597-1-git-send-email-eddie.wai@broadcom.com>
On 06/10/2013 01:34 PM, Eddie Wai wrote:
> index fe7f06c..f9cc89b 100644
> --- a/include/scsi/iscsi_if.h
> +++ b/include/scsi/iscsi_if.h
> @@ -487,6 +487,10 @@ enum iscsi_param {
> ISCSI_PARAM_TGT_RESET_TMO,
> ISCSI_PARAM_TARGET_ALIAS,
>
> + ISCSI_PARAM_BOOT_ROOT,
> + ISCSI_PARAM_BOOT_NIC,
> + ISCSI_PARAM_BOOT_TARGET,
> +
> ISCSI_PARAM_CHAP_IN_IDX,
> ISCSI_PARAM_CHAP_OUT_IDX,
> /* must always be last */
We cannot add in the middle because it would screw up older tools and
kernels. Just add adter the CHAP ones at the end.
Other than that patch looks ok.
prev parent reply other threads:[~2013-06-20 15:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Eddie Wai>
2013-06-10 18:34 ` [PATCH] LIBISCSI: Added new boot entries in the session sysfs Eddie Wai
2013-06-20 15:57 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C3264E.7080802@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=eddie.wai@broadcom.com \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.