All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "Steven Rostedt" <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, "Ingo Molnar" <mingo@kernel.org>,
	"Frederic Weisbecker" <fweisbec@gmail.com>,
	"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [for-next][PATCH 08/12] tracing: Add binary & filter for events
Date: Thu, 20 Jun 2013 20:28:13 +0200	[thread overview]
Message-ID: <51C349BD.4030403@broadcom.com> (raw)
In-Reply-To: <1371730487.18733.72.camel@gandalf.local.home>

On 06/20/13 14:14, Steven Rostedt wrote:
> On Thu, 2013-06-20 at 10:09 +0200, Arend van Spriel wrote:
>> On 06/20/2013 05:35 AM, Steven Rostedt wrote:
>>> By allowing a binary '&' operation, this gives the user the ability to
>>> test a bit.
>>>
>>> Note, a binary '|' is not added, as it doesn't make sense as fields must
>>> be compared to constants (for now), and ORing a constant will always return
>>> true.
>>>
>>> Link:http://lkml.kernel.org/r/1371057385.9844.261.camel@gandalf.local.home
>>>
>>> Suggested-by: Arend van Spriel<arend@broadcom.com>
>>
>> Actually, my attempt was triggered by the trace-cmd manual page:
>>
>> "-f filter
>> Specify a filter for the previous event. This must come after a -e. This
>> will filter what events get recorded based on the content of the event.
>> Filtering is passed to the kernel directly so what filtering is allowed
>> may depend on what version of the kernel you have. Basically, it will
>> let you use C notation to check if an event should be processed or not.
>>
>> ==,>=,<=,>,<,&, |,&&  and ||
>>
>> The above are usually safe to use to compare fields."
>
> Ah thanks. That needs to be updated. Not sure why I wrote all of them.
> Perhaps because the report side handles them and I just assumed the
> kernel did too.

Reading the whole text with your remark in mind, I guess it does 
indicate there are no guarantees depending on the kernel and the list of 
operators are what trace-cmd supports. I overlooked/ignored the text 
seeing the operators.

Regards,
Arend


  reply	other threads:[~2013-06-20 18:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20  3:35 [for-next][PATCH 00/12] tracing: Updates and minor fixes for 3.11 Steven Rostedt
2013-06-20  3:35 ` [for-next][PATCH 01/12] tracing: Add function probe to trigger a ftrace dump to console Steven Rostedt
2013-06-20  3:35 ` [for-next][PATCH 02/12] tracing: Add function probe to trigger a ftrace dump of current CPU trace Steven Rostedt
2013-06-20  3:35 ` [for-next][PATCH 03/12] tracing/trivial: Consolidate error return condition Steven Rostedt
2013-06-20  3:35 ` [for-next][PATCH 04/12] tracing: Fix file mode of free_buffer Steven Rostedt
2013-06-20  3:35 ` [for-next][PATCH 05/12] ftrace: Use schedule_on_each_cpu() as a heavy synchronize_sched() Steven Rostedt
2013-06-20  3:35 ` [for-next][PATCH 06/12] ftrace: Remove ftrace_regex_lseek() Steven Rostedt
2013-06-20  3:35 ` [for-next][PATCH 07/12] tracing: Do not call kmem_cache_free() on allocation failure Steven Rostedt
2013-06-20  3:35 ` [for-next][PATCH 08/12] tracing: Add binary & filter for events Steven Rostedt
2013-06-20  8:09   ` Arend van Spriel
2013-06-20 12:14     ` Steven Rostedt
2013-06-20 18:28       ` Arend van Spriel [this message]
2013-06-20 18:34         ` Steven Rostedt
2013-06-20 18:38           ` Steven Rostedt
2013-06-20 19:15             ` Arend van Spriel
2013-06-20  3:35 ` [for-next][PATCH 09/12] tracing: Update documentation on tracepoint glob matching Steven Rostedt
2013-06-20  3:35 ` [for-next][PATCH 10/12] tracing: Disable tracing on warning Steven Rostedt
2013-06-20  3:35 ` [for-next][PATCH 11/12] tracing/kprobes: Remove unnecessary checking of trace_probe_is_enabled Steven Rostedt
2013-06-20  3:35 ` [for-next][PATCH 12/12] ftrace: Fix stddev calculation in function profiler Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C349BD.4030403@broadcom.com \
    --to=arend@broadcom.com \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.