diff for duplicates of <51C3A363.5090206@cogentembedded.com> diff --git a/a/1.txt b/N1/1.txt index 0a0a6ec..798d7c4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -26,7 +26,7 @@ Guennadi Liakhovetski wrote: >> + dmr = 0; >> + break; >> + case V4L2_PIX_FMT_RGB32: ->> + if (priv->chip = RCAR_H1 || priv->chip = RCAR_E1) { +>> + if (priv->chip == RCAR_H1 || priv->chip == RCAR_E1) { >> + dmr = VNDMR_EXRGB; >> + break; >> + } @@ -103,7 +103,7 @@ Shouldn't the ".packing" be changed here to SOC_MBUS_PACKING_2X8_PADHI ? No. In case the subdevice drivers does not implement cropping (i.e there is no both methods g_crop and cropcap) then the return value is -ENOIOCTLCMD. -Don't you suggest to continue for (ret = -ENOIOCTLCMD) and return for +Don't you suggest to continue for (ret == -ENOIOCTLCMD) and return for other (ret < 0) ? >> + switch (pixfmt) { diff --git a/a/content_digest b/N1/content_digest index 3dff380..5661c87 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\0Pine.LNX.4.64.1306131245420.31976@axis700.grange\0" "From\0Vladimir Barinov <vladimir.barinov@cogentembedded.com>\0" "Subject\0Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver\0" - "Date\0Fri, 21 Jun 2013 00:50:43 +0000\0" + "Date\0Fri, 21 Jun 2013 04:50:43 +0400\0" "To\0Guennadi Liakhovetski <g.liakhovetski@gmx.de>\0" "Cc\0Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>" mchehab@redhat.com @@ -41,7 +41,7 @@ ">> +\t\tdmr = 0;\n" ">> +\t\tbreak;\n" ">> +\tcase V4L2_PIX_FMT_RGB32:\n" - ">> +\t\tif (priv->chip = RCAR_H1 || priv->chip = RCAR_E1) {\n" + ">> +\t\tif (priv->chip == RCAR_H1 || priv->chip == RCAR_E1) {\n" ">> +\t\t\tdmr = VNDMR_EXRGB;\n" ">> +\t\t\tbreak;\n" ">> +\t\t}\n" @@ -118,7 +118,7 @@ "No.\n" "In case the subdevice drivers does not implement cropping (i.e there is \n" "no both methods g_crop and cropcap) then the return value is -ENOIOCTLCMD.\n" - "Don't you suggest to continue for (ret = -ENOIOCTLCMD) and return for \n" + "Don't you suggest to continue for (ret == -ENOIOCTLCMD) and return for \n" "other (ret < 0) ?\n" "\n" ">> +\tswitch (pixfmt) {\n" @@ -164,4 +164,4 @@ "Regards,\n" Vladimir -75332a31b5f7dac4d1a745285ee353fe28b137c8fb812b937f2878600d08670a +64134c6ae5220e11821e3950f0ff6eaf6a3444e02b3f602fc63a77ade86f08d0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.