From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mihai Moldovan Date: Fri, 21 Jun 2013 05:12:55 +0200 Subject: [ath9k-devel] Dropped frames (unauthorized port) in AP mode In-Reply-To: <51C0D052.2000206@ionic.de> References: <51C0D052.2000206@ionic.de> Message-ID: <51C3C4B7.9040300@ionic.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org * On 18.06.2013 11:25 PM, Mihai Moldovan wrote: > [...] > Looking at the kernel source (net/mac80211/tx.c), this condition is being triggered: > > if (unlikely(!ieee80211_vif_is_mesh(&sdata->vif) && > !is_multicast_ether_addr(hdr.addr1) && !authorized && > (cpu_to_be16(ethertype) != sdata->control_port_protocol || > !ether_addr_equal(sdata->vif.addr, skb->data + ETH_ALEN)))) Fugly print-debugged this statement, and I'm heavily confused. The subcondition "cpu_to_be16(ethertype) != sdata->control_port_protocol" is true for me! Thus, I checked "sdata->control_port_protocol", which is ETH_P_PAE (0x888E)... i.e., 802.1X. Great for WiFi authentication. "ethertype", on the other hand, is ETH_P_DDCMP (0x0006) which left me totally confused! How is this possible? ethertype should ideally also be ETH_P_PAE, definitely not some only internally used DECnet port protocol. Yes, CONFIG_DECNET is turned on in my kernel config, but I'm not (actively) even using DECnet. ethertype is set from the socket buffer's data (ethertype = (skb->data[12] << 8) | skb->data[13]), but what is generating this packet? If the ethertype fetching is actually correct in net/mac80211/tx.c, what would ever set it to 0x0006? CCing Johannes Berg, as git is "blaming" him for those line(s) (originally Jiri Benc, but I haven't seen list posts in a while, assuming he's not maintaining anymore.) -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 4506 bytes Desc: S/MIME Cryptographic Signature Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20130621/f361827a/attachment.bin