From: Lars-Peter Clausen <lars@metafoo.de>
To: Rajeev kumar <rajeev-dlh.kumar@st.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@kernel.org" <broonie@kernel.org>,
Daniel Mack <zonque@gmail.com>
Subject: Re: [PATCH 1/3] ASoC: codecs: adau1701: allow configuration of PLL mode pins
Date: Fri, 21 Jun 2013 10:18:08 +0200 [thread overview]
Message-ID: <51C40C40.4000604@metafoo.de> (raw)
In-Reply-To: <51C40B7E.1090508@st.com>
On 06/21/2013 10:14 AM, Rajeev kumar wrote:
> On 6/21/2013 11:36 AM, Daniel Mack wrote:
>>>> >> struct snd_soc_codec *codec = dai->codec;
>>>> >> + struct adau1701 *adau1701 = snd_soc_codec_get_drvdata(codec);
>>>> >> snd_pcm_format_t format;
>>>> >> unsigned int val;
>>>> >>
>>>> >> + if (adau1701->sysclk) {
>>>> >> + unsigned int clkdiv = adau1701->sysclk / params_rate(params);
>>> >
>>> > It will give warning.
>> Please elaborate.
>
> you are declaring something (unsigned int clkdiv) in between code.
>
It's at the beginning at a block, that's actually fine. Neither checkpatch
or gcc will generate a warning.
next prev parent reply other threads:[~2013-06-21 8:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 17:29 [PATCH v2 0/3] ASoC: codecs: some more improvements for adau1701 Daniel Mack
2013-06-20 17:29 ` [PATCH 1/3] ASoC: codecs: adau1701: allow configuration of PLL mode pins Daniel Mack
2013-06-21 4:46 ` Rajeev kumar
2013-06-21 6:06 ` Daniel Mack
2013-06-21 8:14 ` Rajeev kumar
2013-06-21 8:17 ` Daniel Mack
2013-06-21 8:18 ` Lars-Peter Clausen [this message]
2013-06-21 7:23 ` Lars-Peter Clausen
2013-06-21 7:31 ` Daniel Mack
2013-06-21 7:39 ` Lars-Peter Clausen
2013-06-20 17:29 ` [PATCH 2/3] ASoC: codecs: adau1701: switch to direct regmap API usage Daniel Mack
2013-06-21 7:28 ` Lars-Peter Clausen
2013-06-21 7:31 ` Daniel Mack
2013-06-20 17:29 ` [PATCH 3/3] ASoC: codecs: adau1701: add support for pin muxing Daniel Mack
2013-06-21 7:24 ` Lars-Peter Clausen
2013-06-21 7:28 ` Daniel Mack
2013-06-21 7:35 ` Lars-Peter Clausen
2013-06-21 7:38 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C40C40.4000604@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=rajeev-dlh.kumar@st.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.