From: George Dunlap <george.dunlap@eu.citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
Hanweidong <hanweidong@huawei.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xen.org,
Stefano Stabellini <stefano.stabellini@citrix.com>
Subject: Re: [PATCH v3 1/8] hvmloader: Remove all 64-bit print arguments
Date: Fri, 21 Jun 2013 09:37:38 +0100 [thread overview]
Message-ID: <51C410D2.6060607@eu.citrix.com> (raw)
In-Reply-To: <20931.14127.431627.799759@mariner.uk.xensource.com>
On 20/06/13 18:09, Ian Jackson wrote:
> Stefano Stabellini writes ("Re: [PATCH v3 1/8] hvmloader: Remove all 64-bit print arguments"):
>> What's the issue with implementing %llx?
> Isn't this an endless series of just-before-release yaks ?
>
> If it were me I would have left the %llx alone.
I needed to print the 64-bit values for diagnostic purposes,
particularly when testing boundary conditions; that's why I did the
manual break-down.
Changing the faked-up printf to handle uint64_t wasn't too difficult,
but it required implementing a 64-bit integer division, which was more
than I was up for.
-George
next prev parent reply other threads:[~2013-06-21 8:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 16:33 [PATCH 0/8] Relocate devices rather than memory for qemu-xen George Dunlap
2013-06-20 16:33 ` [PATCH v3 1/8] hvmloader: Remove all 64-bit print arguments George Dunlap
2013-06-20 17:06 ` Stefano Stabellini
2013-06-20 17:09 ` Ian Jackson
2013-06-21 8:37 ` George Dunlap [this message]
2013-06-21 8:34 ` George Dunlap
2013-06-21 9:22 ` George Dunlap
2013-06-21 10:23 ` Ian Jackson
2013-06-20 16:33 ` [PATCH v3 2/8] hvmloader: Make the printfs more informative George Dunlap
2013-06-20 17:12 ` Stefano Stabellini
2013-06-21 9:35 ` George Dunlap
2013-06-21 9:50 ` George Dunlap
2013-06-21 10:53 ` Stefano Stabellini
2013-06-21 10:53 ` Stefano Stabellini
2013-06-21 10:35 ` Ian Jackson
2013-06-20 16:33 ` [PATCH v3 3/8] hvmloader: Set up highmem resouce appropriately if there is no RAM above 4G George Dunlap
2013-06-20 17:16 ` Stefano Stabellini
2013-06-21 7:01 ` Jan Beulich
2013-06-21 9:06 ` George Dunlap
2013-06-21 10:38 ` Ian Jackson
2013-06-20 16:33 ` [PATCH v3 4/8] hvmloader: Fix check for needing a 64-bit bar George Dunlap
2013-06-20 16:33 ` [PATCH v3 5/8] hvmloader: Correct bug in low mmio region accounting George Dunlap
2013-06-20 17:20 ` Stefano Stabellini
2013-06-21 7:09 ` Jan Beulich
2013-06-20 16:33 ` [PATCH v3 6/8] hvmloader: Load large devices into high MMIO space as needed George Dunlap
2013-06-20 17:23 ` Stefano Stabellini
2013-06-21 7:12 ` Jan Beulich
2013-06-20 16:33 ` [PATCH v3 7/8] hvmloader: Remove minimum size for BARs to relocate to 64-bit space George Dunlap
2013-06-20 16:33 ` [PATCH v3 8/8] libxl, hvmloader: Don't relocate memory for MMIO hole George Dunlap
2013-06-20 17:38 ` Stefano Stabellini
2013-06-21 8:31 ` George Dunlap
2013-06-21 10:22 ` [PATCH v3 1/8] hvmloader: Remove all 64-bit print arguments [and 1 more messages] Ian Jackson
2013-06-21 11:21 ` [PATCH v3 8/8] libxl, hvmloader: Don't relocate memory for MMIO hole Stefano Stabellini
2013-06-21 11:31 ` Ian Jackson
2013-06-21 7:17 ` Jan Beulich
2013-06-21 8:32 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C410D2.6060607@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=hanweidong@huawei.com \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.