Re: [Qemu-devel] [PATCH v5 10/11] blockdev: add Abort transaction

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1554 bytes --]

On 06/19/2013 12:21 PM, Kevin Wolf wrote:
> Am 03.06.2013 um 11:21 hat Stefan Hajnoczi geschrieben:
>> On Thu, May 30, 2013 at 07:11:25AM -0600, Eric Blake wrote:
>>> On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote:
>>>> The Abort action can be used to test QMP 'transaction' failure.  Add it
>>>> as the last action to exercise the .abort() and .cleanup() code paths
>>>> for all previous actions.
>>>
>>> Another thread questioned whether we should name this action
>>> __org.qemu-debug-abort, if only to be clear that it is not a normal
>>> interface.
>>
>> kwolf: Do you want Abort to be namespaced as a debug-only action?
>>
>> I think it's perfectly supportable so there's no need to hide it.
>> Granted it's rare that anyone would want to use this action.
> 
> I don't have a strong opinion on this. On the one hand it's probably
> useless outside testing and debugging, on the other hand it won't be a
> pain to support and the interface looks like it could be stable for
> the next few years...
> 
> It's your patch, so you get to decide.

I don't have a strong opinion, either - it doesn't matter what it is
named if no one outside of qtest uses that name :)  When developing
libvirt interfaces around new actions, I might use an abort to
intentionally test behavior of libvirt error-handling code, but that
would still be something I do by hand (by any name) and not something
coded into libvirt itself.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]