From: Daniel Mack <zonque@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, lars@metafoo.de
Subject: Re: [PATCH v3 1/3] ASoC: codecs: adau1701: allow configuration of PLL mode pins
Date: Fri, 21 Jun 2013 19:46:18 +0200 [thread overview]
Message-ID: <51C4916A.3080008@gmail.com> (raw)
In-Reply-To: <20130621150019.GZ27646@sirena.org.uk>
On 21.06.2013 17:00, Mark Brown wrote:
> On Fri, Jun 21, 2013 at 09:54:42AM +0200, Daniel Mack wrote:
>
>> To avoid excessive reset cycles and firmware downloads, the default
>> clock divider can be specified in DT as well. Whenever a ratio change is
>> detected in the hw_params callback, the PLL mode lines are updates and a
>> full reset cycle is issued.
>
> Why isn't it enough to just use the first setting we see - I'd expect
> the device to normally be powered off before audio starts including when
> hw_params() is called?
>
Hmm, then we would postpone the firmware download to the first hw_params
call in all cases. That could also work, but it'll need some rework.
I'll post new patches the next days.
Daniel
next prev parent reply other threads:[~2013-06-21 17:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 7:54 [PATCH v3 0/3] ASoC: codecs: some more improvements for adau1701 Daniel Mack
2013-06-21 7:54 ` [PATCH v3 1/3] ASoC: codecs: adau1701: allow configuration of PLL mode pins Daniel Mack
2013-06-21 8:09 ` Lars-Peter Clausen
2013-06-21 15:00 ` Mark Brown
2013-06-21 17:46 ` Daniel Mack [this message]
2013-06-22 22:10 ` [ucm] Adding list for caching multiple opened control devices sajeesh sidharthan
2013-06-24 17:09 ` Daniel Mack
2013-06-25 6:10 ` Takashi Iwai
2013-06-21 7:54 ` [PATCH v3 2/3] ASoC: codecs: adau1701: switch to direct regmap API usage Daniel Mack
2013-06-21 8:09 ` Lars-Peter Clausen
2013-06-21 7:54 ` [PATCH v3 3/3] ASoC: codecs: adau1701: add support for pin muxing Daniel Mack
2013-06-21 8:09 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C4916A.3080008@gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.