From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Seiji Aguchi <seiji.aguchi@hds.com>
Subject: Re: [PATCH][GIT PULL] trace,x86: Move creation of irq tracepoints from apic.c to irq.c
Date: Fri, 21 Jun 2013 14:54:07 -0700 [thread overview]
Message-ID: <51C4CB7F.2000306@linux.intel.com> (raw)
In-Reply-To: <1371850091.18733.136.camel@gandalf.local.home>
On 06/21/2013 02:28 PM, Steven Rostedt wrote:
> On Fri, 2013-06-21 at 14:13 -0700, H. Peter Anvin wrote:
>> On 06/21/2013 02:09 PM, Steven Rostedt wrote:
>>> Call Trace:
>>> [<ffffffff8103539d>] do_fork+0xa8/0x260
>>> [<ffffffff810ca7b1>] ? trace_preempt_on+0x2a/0x2f
>>> [<ffffffff812afb3e>] ? trace_hardirqs_on_thunk+0x3a/0x3f
>>
>> This bit of the call chain seems a little odd, no?
>
> Doesn't the "?" mean its just in the stack but not part of the call
> frame that was used. CONFIG_FRAME_POINTER is set in the config.
>
> With lockdep and preempt tracing enabled, why would this seem strange?
>
I didn't think trace_hardirqs_on_thunk called trace_preempt_on but maybe
I misread the code.
-hpa
next prev parent reply other threads:[~2013-06-21 21:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 17:31 [PATCH][GIT PULL] trace,x86: Move creation of irq tracepoints from apic.c to irq.c Steven Rostedt
2013-06-21 20:48 ` H. Peter Anvin
2013-06-23 9:03 ` Ingo Molnar
2013-06-23 9:43 ` Ingo Molnar
2013-06-21 21:09 ` Steven Rostedt
2013-06-21 21:13 ` H. Peter Anvin
2013-06-21 21:28 ` Steven Rostedt
2013-06-21 21:54 ` H. Peter Anvin [this message]
2013-06-21 21:26 ` Steven Rostedt
2013-06-22 14:17 ` Steven Rostedt
2013-06-22 17:42 ` Seiji Aguchi
2013-06-22 18:46 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C4CB7F.2000306@linux.intel.com \
--to=hpa@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=seiji.aguchi@hds.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.