From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UqCNd-0007cL-JE for qemu-devel@nongnu.org; Fri, 21 Jun 2013 21:12:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UqCNa-0003d0-OO for qemu-devel@nongnu.org; Fri, 21 Jun 2013 21:12:41 -0400 Received: from mail-pb0-x22d.google.com ([2607:f8b0:400e:c01::22d]:38316) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UqCNa-0003cm-Hf for qemu-devel@nongnu.org; Fri, 21 Jun 2013 21:12:38 -0400 Received: by mail-pb0-f45.google.com with SMTP id mc8so8538594pbc.18 for ; Fri, 21 Jun 2013 18:12:37 -0700 (PDT) Message-ID: <51C4F9FF.3040304@ozlabs.ru> Date: Sat, 22 Jun 2013 11:12:31 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1371837137.11064.23@snotra> In-Reply-To: <1371837137.11064.23@snotra> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] KVM: PPC: enable irqfd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Scott Wood Cc: Anthony Liguori , qemu-devel@nongnu.org, Alexander Graf , Alex Williamson , qemu-ppc@nongnu.org, David Gibson On 06/22/2013 03:52 AM, Scott Wood wrote: > On 06/21/2013 04:22:55 AM, Alexey Kardashevskiy wrote: >> Signed-off-by: Alexey Kardashevskiy >> --- >> target-ppc/kvm.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c >> index d6da146..e72c335 100644 >> --- a/target-ppc/kvm.c >> +++ b/target-ppc/kvm.c >> @@ -1973,6 +1973,8 @@ int kvm_arch_on_sigbus(int code, void *addr) >> >> void kvm_arch_init_irq_routing(KVMState *s) >> { >> + kvm_irqfds_allowed = true; >> + kvm_msi_via_irqfd_allowed = true; >> } > > Shouldn't this should go in pseries-specific code, as was done for MPIC? > The model of doing IRQ-related things per "arch" rather than per IRQ > subsystem doesn't work well outside of certain architectures such as x86, > where more than just the ISA is standardized. Yes, we discussed with Alex Graf in IRC and I'll post another (sorry :) ) set of patches. It will be something like a kvm_msi_irqfd_enable_direct_mapping flag and using msimessage::data as a virq in that routing function, should be easy and harmless for others. -- Alexey