Re: [BUGFIX v2 0/4] fix bug 56531, 59501 and 59581

[Jiang Liu <liuj97@gmail.com>]

On 06/22/2013 08:13 AM, Rafael J. Wysocki wrote:
> On Saturday, June 22, 2013 12:54:21 AM Jiang Liu wrote:
>> On 06/21/2013 03:06 AM, Rafael J. Wysocki wrote:
>>> On Wednesday, June 19, 2013 11:18:41 AM Alexander E. Patrakov wrote:
>>>> 2013/6/19 Rafael J. Wysocki <rjw@sisk.pl>:
>>>>> OK, let's try to untangle this a bit.
>>>>>
>>>>> If you applyt patches [1/4] and [4/4] from the $subject series only, what
>>>>> does remain unfixed?
>>>>
>>>> [not tested, can do so in 12 hours if needed]
>>>>
>>>> I think there will be problems on undocking and/or on the second
>>>> docking, as described in comments #6 - #8 of
>>>> https://bugzilla.kernel.org/show_bug.cgi?id=59501
>>>
>>> OK, I think I have something that might work.  It may not solve all problems,
>>> but maybe it helps a bit.  Unfortunately, I can't really test it, so please do
>>> if you can.
>>>
>>> Please apply [1/4] and [4/4] and the one below and see what happens.
>>>
>>> Thanks,
>>> Rafael
>>>
>>>
>>> ---
>>> Rationale:
>>> 	acpiphp_glue.c:disable_device() trims the underlying ACPI device objects
>>> 	after removing the companion PCI devices, so the dock station code
>>> 	doesn't need to trim them separately for the dependent devices handled
>>> 	by acpiphp.
>>>
>>> 	Moreover, acpiphp_glue.c is the only user of
>>> 	[un]register_hotplug_dock_device(), so *all* devices on the
>>> 	ds->hotplug_devices list are handled by acpiphp and ops is set for all
>>> 	of them.
>> Hi Rafael,
>>     There's an ongoing patch to fix a disk bay hotplug regression, which
>> may add a second caller of register_hotplug_device(). Please refer to
>> bug 59871, and the proposed patch is at:
>> https://bugzilla.kernel.org/attachment.cgi?id=105581
Hi Rafael,
    You can find the proposed patch for ATA Bay hotplug at
https://bugzilla.kernel.org/attachment.cgi?id=105581
Regards!
Gerry

>>
>> The proposed patch for bug 59871 may not be safe with above changes
>> because the ACPI ATA hotplug handler may not remove ACPI devices as
>> acpiphp driver does.
> 
> Well, since there's not ATA hotplug handler in 3.10-rc6, as far as I can say,
> I suppose that you're talking about a new patch scheduled for 3.11.  If so,u
> can you please give me a pointer to that patch, possibly the tree it is
> queued on etc.?
[...]
> 
> Thanks,
> Rafael
> 
>