From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomonari Horikoshi Subject: [PATCH][RFC] correction trouble of short message in UDP Date: Thu, 25 Jan 2007 20:04:10 +0900 Message-ID: <51C740708A201Ft.horikoshi@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-TlvgVug2DhFpTJ2rQewOJ" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-ia64-devel-bounces@lists.xensource.com Errors-To: xen-ia64-devel-bounces@lists.xensource.com To: xen-devel Cc: xen-ia64-devel List-Id: xen-devel@lists.xenproject.org --Boundary-TlvgVug2DhFpTJ2rQewOJ Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Content-Description: Mail message body Hi all. I modified the patch to the following trouble. "When I executed "netperf" by a short message of UDP, PV domain issued Call trace." This error occurs because earliness grant is filled from the queue check of tx_slot when a lot of message is sent. I stopped "Add netfornt tx_queue_len" being used, and I was added to check gnttab_empty_grant_references() in netfront_tx_slot_available(). I confirmed the not error because of this correction. Is there a better correction? Best regards. Tomonari Horikoshi, Tomonari Horikoshi wrote:---------------------- Sent: Thu, 25 Jan 2007 13:44:30 +0900 Subject: Re: [Xen-devel] [PATCH] Add netfornt tx_queue_len > Hi Herbert-san > > Thank you for your comment. > > I agreed. > I examine the another way. > > It is likely to go well if something is added to the check > on netfront_tx_slot_available(). > > Best regards. > > Tomonari Horikoshi, > > Herbert Xu wrote:---------------------- > Sent: Wed, 24 Jan 2007 13:29:51 +1100 > Subject: Re: [Xen-devel] [PATCH] Add netfornt tx_queue_len > > > On Wed, Jan 24, 2007 at 01:37:55AM +0000, Tomonari Horikoshi wrote: > > > > > > When I executed "netperf" by a short message of UDP, > > > PV domain and PV-on-HVM driver issued Call trace. > > > > > > I think that GrantEntry was filled with a lot of messages processings. > > > > > > This problem is generated in IA64 only. > > > Probably, I think that I am the following problems. > > > > > > In IA64 > > > NET_TX_RING_SIZE 1024, NR_GRANT_ENTRIES 2048 > > > In x86 > > > NET_TX_RING_SIZE 256, NR_GRANT_ENTRIES 2048 > > > > > > I corrected to check "number of unprocessing queue > tx_queue_len" before Grant was filled. > > > > > > However, my correction influences x86. > > > Please teach to me in that when there is a better improvement. > > > > Sorry, but this patch looks bogus. The tx queue is maintained by > > Linux and has nothing to do with the driver. So limiting its length > > based on internal state of the driver can't be right. > > > > We need to find out what's really going wrong with the grant table > > entries here. > > > > Cheers, --Boundary-TlvgVug2DhFpTJ2rQewOJ Content-Type: application/octet-stream; name="netfront_chk_grant.patch" Content-Disposition: attachment; filename="netfront_chk_grant.patch" Content-Transfer-Encoding: base64 IyBIRyBjaGFuZ2VzZXQgcGF0Y2gKIyBVc2VyIHQuaG9yaWtvc2hpQGpwLmZ1amlzdS5jb20K IyBEYXRlIDExNjk3MTIzNDkgLTMyNDAwCiMgTm9kZSBJRCBmZWY2NzJiNTZlNzdlZDZjZTY2 ZmM2Yjk3Yjg5YmM0ZThjNjc3YjZhCiMgUGFyZW50ICBiNGRmN2RlMGNiZjc1MzBjMzI0ODk1 NjI0M2JjOWM1MjBkYjJkNjA5Cm5ldGZyb250IGFkZCBjaGVjayBncmFudCByZWZlcmVuY2UK ClNpZ25lZC1vZmYtYnk6IFRvbW9uYXJpIEhvcmlrb3NoaSA8dC5ob3Jpa29zaGlAanAuZnVq aXRzdS5jb20+CgpkaWZmIC1yIGI0ZGY3ZGUwY2JmNyAtciBmZWY2NzJiNTZlNzcgbGludXgt Mi42LXhlbi1zcGFyc2UvZHJpdmVycy94ZW4vbmV0ZnJvbnQvbmV0ZnJvbnQuYwotLS0gYS9s aW51eC0yLjYteGVuLXNwYXJzZS9kcml2ZXJzL3hlbi9uZXRmcm9udC9uZXRmcm9udC5jCVdl ZCBKYW4gMjQgMTI6Mjg6MDUgMjAwNyAtMDcwMAorKysgYi9saW51eC0yLjYteGVuLXNwYXJz ZS9kcml2ZXJzL3hlbi9uZXRmcm9udC9uZXRmcm9udC5jCVRodSBKYW4gMjUgMTc6MDU6NDkg MjAwNyArMDkwMApAQCAtNjEzLDYgKzYxMyw5IEBAIHN0YXRpYyBpbnQgbmV0d29ya19vcGVu KHN0cnVjdCBuZXRfZGV2aWMKIAogc3RhdGljIGlubGluZSBpbnQgbmV0ZnJvbnRfdHhfc2xv dF9hdmFpbGFibGUoc3RydWN0IG5ldGZyb250X2luZm8gKm5wKQogeworCWlmKCBnbnR0YWJf ZW1wdHlfZ3JhbnRfcmVmZXJlbmNlcygmbnAtPmdyZWZfdHhfaGVhZCkgKQorCQlyZXR1cm4g MDsKKwogCXJldHVybiBSSU5HX0ZSRUVfUkVRVUVTVFMoJm5wLT50eCkgPj0gTUFYX1NLQl9G UkFHUyArIDI7CiB9CiAK --Boundary-TlvgVug2DhFpTJ2rQewOJ Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel --Boundary-TlvgVug2DhFpTJ2rQewOJ--