Re: [PATCH] regulator: max77693: Add max77693 regualtor driver.

[jonghwa3.lee@samsung.com]

Hi,
On 2013년 06월 22일 00:19, Mark Brown wrote:

> On Thu, Jun 20, 2013 at 04:03:26PM +0900, Jonghwa Lee wrote:
>> This patch adds new regulator driver to support max77693 chip's regulators.
>> max77693 has two linear voltage regulators and one current regulator which
>> can be controlled through I2C bus. This driver also supports device tree.
> 
> This is fine but doesn't have a binding document which is needed for new
> DT bindings.
> 


I'd like to add binding document to max77693 mfd's but it is still in progress
(https://lkml.org/lkml/2013/4/9/221). I think I can updates it when the patch
is merged. Do you think I have to wait for merging? Or just add document under
regulator/ this time ,and then move it to mfd/ later? Which one do you think better?

> A comment in the is_enabled() function explaining that more than one bit
> might be set (or replacing it with the generic function) would also be
> good.


Yes, the charger regulator needs two bits for checking enabling. I'll add the
comment about it.

Thanks,
Jonghwa