From: Jack Wang <jinpu.wang@profitbricks.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Joe Lawrence <jdl1291@gmail.com>, Tejun Heo <tj@kernel.org>,
Chanho Min <chanho.min@lge.com>,
David Milburn <dmilburn@redhat.com>,
Hannes Reinecke <hare@suse.de>,
Mike Christie <michaelc@cs.wisc.edu>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: RE:[PATCH v11 6/9] Make scsi_remove_host() wait until error handling finished
Date: Mon, 24 Jun 2013 12:17:33 +0200 [thread overview]
Message-ID: <51C81CBD.5070709@profitbricks.com> (raw)
> @@ -646,14 +703,20 @@ static int scsi_try_target_reset(struct scsi_cmnd *scmd)
> static int scsi_try_bus_device_reset(struct scsi_cmnd *scmd)
> {
> int rtn;
> - struct scsi_host_template *hostt = scmd->device->host->hostt;
> + struct Scsi_Host *host = scmd->device->host;
> + struct scsi_host_template *hostt = host->hostt;
>
> if (!hostt->eh_device_reset_handler)
> return FAILED;
>
> + if (scsi_begin_eh(host))
> + return FAST_IO_FAIL;
> +
> rtn = hostt->eh_device_reset_handler(scmd);
> if (rtn == SUCCESS)
> __scsi_report_device_reset(scmd->device, NULL);
> + scsi_end_eh(host);
> +
> return rtn;
> }
As the new eh from Hannes haven't make it into mainline, maybe we still
need also check scsi_try_to_abort_cmd?
Jack
next reply other threads:[~2013-06-24 10:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 10:17 Jack Wang [this message]
2013-06-24 10:53 ` [PATCH v11 6/9] Make scsi_remove_host() wait until error handling finished Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C81CBD.5070709@profitbricks.com \
--to=jinpu.wang@profitbricks.com \
--cc=bvanassche@acm.org \
--cc=chanho.min@lge.com \
--cc=dmilburn@redhat.com \
--cc=hare@suse.de \
--cc=jdl1291@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.