Re: [PATCH 4/6] cgroup: clean up find_css_set() and friends

[Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>]

On 2013/6/22 9:34, Tejun Heo wrote:
> find_css_set() passes uninitialized on-stack template[] array to
> find_existing_css_set() which sets the entries for all subsystems.
> Passing around an uninitialized array is a bit icky and we want to
> introduce an iterator which only iterates loaded subsystems.  Let's
> initialize it on definition.
> 
> While at it, also make the following cosmetic cleanups.
> 
> * Convert to proper /** comments.
> 

I thought we only use this for external functions, but then I read
Documentation/kernel-doc-nano-HOWTO.txt:

We also recommend providing kernel-doc formatted documentation
for private (file "static") routines, for consistency of kernel
source code layout.  But this is lower priority and at the
discretion of the MAINTAINER of that kernel source file.

> * Reorder variable declarations.
> 
> * Replace comment on synchronization with lockdep_assert_held().
> 
> This patch doesn't make any functional differences.
> 
> Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
>  kernel/cgroup.c | 38 +++++++++++++++++---------------------
>  1 file changed, 17 insertions(+), 21 deletions(-)
> 

Acked-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>