From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA Date: Mon, 24 Jun 2013 16:53:40 +0530 Message-ID: <51C82C3C.8040506@ti.com> References: <1371762407-24544-1-git-send-email-joelagnel@ti.com> <201306211632.12577.arnd@arndb.de> <201306212044.26677.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org To: Joel A Fernandes Cc: Linux Documentation List , Tony Lindgren , Koen Kooi , Grant Likely , Russell King , Vinod Koul , Arnd Bergmann , Devicetree Discuss , Rob Herring , Jason Kridner , Linux OMAP List , Linux ARM Kernel List , Joel A Fernandes , Linux DaVinci Kernel List , Benoit Cousson , Mark Brown , Linux MMC List Linux List-Id: linux-mmc@vger.kernel.org On 6/22/2013 3:23 AM, Joel A Fernandes wrote: > Hi Arnd, > > On Fri, Jun 21, 2013 at 1:44 PM, Arnd Bergmann wrote: >> On Friday 21 June 2013, Joel A Fernandes wrote: >>> I think we are talking about different things, I agree the 'select >>> DMADEVICES' can be dropped but lets please keep the default y option >>> (not adding new select statements, just saying that if someone select >>> DMADEVICES in menuconfig and if they're ARCH_OMAP=1 , then default to >>> EDMA). This will simply allow people to have a default. Thanks. >> >> Yes, that's ok. > > Ok, thanks. I will follow up with a patch in my next submissions that builds it. > > Perhaps a: > default y if 'ARCH_OMAP2PLUS' > > and leave the existing as it is... > default n if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2' > > would make most sense to me. Basically EDMA is seen on current and all > new OMAP2PLUS. OMAP2PLUS devices like OMAP3/4 do not have EDMA so this is not really true. > >> >> config TI_EDMA >> tristate "TI EDMA support" >> default m if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2 >> select DMA_ENGINE >> select DMA_VIRTUAL_CHANNELS > > > > MMC depends on EDMA specially on AM33xx there's no PIO mode AFAIK. The > 'm' option will require some initramfs to load the module when needing > to MMC boot, I suggest lets leave it as y. But there is no reason why it cannot work with PIO, right? Sounds like the right fix is in driver. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA Date: Mon, 24 Jun 2013 16:53:40 +0530 Message-ID: <51C82C3C.8040506@ti.com> References: <1371762407-24544-1-git-send-email-joelagnel@ti.com> <201306211632.12577.arnd@arndb.de> <201306212044.26677.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Linux Documentation List , Tony Lindgren , Koen Kooi , Grant Likely , Russell King , Vinod Koul , Arnd Bergmann , Devicetree Discuss , Rob Herring , Jason Kridner , Linux OMAP List , Linux ARM Kernel List , Joel A Fernandes , Linux DaVinci Kernel List , Benoit Cousson , Mark Brown , Linux MMC List , Linux Ker To: Joel A Fernandes Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org List-Id: linux-spi.vger.kernel.org On 6/22/2013 3:23 AM, Joel A Fernandes wrote: > Hi Arnd, > > On Fri, Jun 21, 2013 at 1:44 PM, Arnd Bergmann wrote: >> On Friday 21 June 2013, Joel A Fernandes wrote: >>> I think we are talking about different things, I agree the 'select >>> DMADEVICES' can be dropped but lets please keep the default y option >>> (not adding new select statements, just saying that if someone select >>> DMADEVICES in menuconfig and if they're ARCH_OMAP=1 , then default to >>> EDMA). This will simply allow people to have a default. Thanks. >> >> Yes, that's ok. > > Ok, thanks. I will follow up with a patch in my next submissions that builds it. > > Perhaps a: > default y if 'ARCH_OMAP2PLUS' > > and leave the existing as it is... > default n if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2' > > would make most sense to me. Basically EDMA is seen on current and all > new OMAP2PLUS. OMAP2PLUS devices like OMAP3/4 do not have EDMA so this is not really true. > >> >> config TI_EDMA >> tristate "TI EDMA support" >> default m if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2 >> select DMA_ENGINE >> select DMA_VIRTUAL_CHANNELS > > > > MMC depends on EDMA specially on AM33xx there's no PIO mode AFAIK. The > 'm' option will require some initramfs to load the module when needing > to MMC boot, I suggest lets leave it as y. But there is no reason why it cannot work with PIO, right? Sounds like the right fix is in driver. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Mon, 24 Jun 2013 16:53:40 +0530 Subject: [PATCH v12 05/11] edma: config: Enable config options for EDMA In-Reply-To: References: <1371762407-24544-1-git-send-email-joelagnel@ti.com> <201306211632.12577.arnd@arndb.de> <201306212044.26677.arnd@arndb.de> Message-ID: <51C82C3C.8040506@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 6/22/2013 3:23 AM, Joel A Fernandes wrote: > Hi Arnd, > > On Fri, Jun 21, 2013 at 1:44 PM, Arnd Bergmann wrote: >> On Friday 21 June 2013, Joel A Fernandes wrote: >>> I think we are talking about different things, I agree the 'select >>> DMADEVICES' can be dropped but lets please keep the default y option >>> (not adding new select statements, just saying that if someone select >>> DMADEVICES in menuconfig and if they're ARCH_OMAP=1 , then default to >>> EDMA). This will simply allow people to have a default. Thanks. >> >> Yes, that's ok. > > Ok, thanks. I will follow up with a patch in my next submissions that builds it. > > Perhaps a: > default y if 'ARCH_OMAP2PLUS' > > and leave the existing as it is... > default n if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2' > > would make most sense to me. Basically EDMA is seen on current and all > new OMAP2PLUS. OMAP2PLUS devices like OMAP3/4 do not have EDMA so this is not really true. > >> >> config TI_EDMA >> tristate "TI EDMA support" >> default m if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2 >> select DMA_ENGINE >> select DMA_VIRTUAL_CHANNELS > > > > MMC depends on EDMA specially on AM33xx there's no PIO mode AFAIK. The > 'm' option will require some initramfs to load the module when needing > to MMC boot, I suggest lets leave it as y. But there is no reason why it cannot work with PIO, right? Sounds like the right fix is in driver. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752091Ab3FXLYt (ORCPT ); Mon, 24 Jun 2013 07:24:49 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:54583 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979Ab3FXLYr (ORCPT ); Mon, 24 Jun 2013 07:24:47 -0400 Message-ID: <51C82C3C.8040506@ti.com> Date: Mon, 24 Jun 2013 16:53:40 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Joel A Fernandes CC: Arnd Bergmann , Joel A Fernandes , Tony Lindgren , Matt Porter , Grant Likely , Rob Herring , Vinod Koul , Mark Brown , Benoit Cousson , Russell King , Rob Landley , Andrew Morton , Jason Kridner , Koen Kooi , Devicetree Discuss , Linux OMAP List , Linux ARM Kernel List , Linux DaVinci Kernel List , Linux Kernel Mailing List , Linux Documentation List , Linux MMC List , Linux SPI Devel List Subject: Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA References: <1371762407-24544-1-git-send-email-joelagnel@ti.com> <201306211632.12577.arnd@arndb.de> <201306212044.26677.arnd@arndb.de> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/22/2013 3:23 AM, Joel A Fernandes wrote: > Hi Arnd, > > On Fri, Jun 21, 2013 at 1:44 PM, Arnd Bergmann wrote: >> On Friday 21 June 2013, Joel A Fernandes wrote: >>> I think we are talking about different things, I agree the 'select >>> DMADEVICES' can be dropped but lets please keep the default y option >>> (not adding new select statements, just saying that if someone select >>> DMADEVICES in menuconfig and if they're ARCH_OMAP=1 , then default to >>> EDMA). This will simply allow people to have a default. Thanks. >> >> Yes, that's ok. > > Ok, thanks. I will follow up with a patch in my next submissions that builds it. > > Perhaps a: > default y if 'ARCH_OMAP2PLUS' > > and leave the existing as it is... > default n if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2' > > would make most sense to me. Basically EDMA is seen on current and all > new OMAP2PLUS. OMAP2PLUS devices like OMAP3/4 do not have EDMA so this is not really true. > >> >> config TI_EDMA >> tristate "TI EDMA support" >> default m if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2 >> select DMA_ENGINE >> select DMA_VIRTUAL_CHANNELS > > > > MMC depends on EDMA specially on AM33xx there's no PIO mode AFAIK. The > 'm' option will require some initramfs to load the module when needing > to MMC boot, I suggest lets leave it as y. But there is no reason why it cannot work with PIO, right? Sounds like the right fix is in driver. Thanks, Sekhar