From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Sender: Kukjin Kim Message-ID: <51C86442.6090406@samsung.com> Date: Tue, 25 Jun 2013 00:22:42 +0900 From: Kukjin Kim MIME-Version: 1.0 Subject: Re: [PATCH v3 11/18] pwm: Add new pwm-samsung driver References: <1371766383-29077-1-git-send-email-tomasz.figa@gmail.com> <1371766383-29077-12-git-send-email-tomasz.figa@gmail.com> <2925617.TjWXJcIKRC@flatron> In-Reply-To: <2925617.TjWXJcIKRC@flatron> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-ID: To: Tomasz Figa Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, Kukjin Kim , Arnd Bergmann , Olof Johansson , Sylwester Nawrocki , =?ISO-8859-1?Q?Heiko_St=FCbner?= , Mark Brown , Thomas Abraham , Thierry Reding On 06/22/13 22:06, Tomasz Figa wrote: > This patch introduces new Samsung PWM driver, which is heavily cleaned, > multiplatform aware and supports DeviceTree based instantiation. > > Since on historical hardware PWM block can be shared with clocksource > driver, a shared spinlock is used to protect access to shared registers, > already exported from the clocksource driver. > > Signed-off-by: Tomasz Figa > --- > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-samsung.c | 601 ++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 602 insertions(+) > create mode 100644 drivers/pwm/pwm-samsung.c > > Changes since v2: > - Replaced __raw_{readl,writel} with {readl,writel}. > - Corrected commit message. > [...] > + of_property_for_each_u32(np, "samsung,pwm-outputs", prop, cur, val) { > + if (val>= SAMSUNG_PWM_NUM) { > + pr_warning("%s: invalid channel index in samsung,pwm-outputs property\n", Just note, checkpatch complains following, so fixed to use pr_warn() when I applied. WARNING: Prefer pr_warn(... to pr_warning(... #471: FILE: drivers/pwm/pwm-samsung.c:432: + pr_warning("%s: invalid channel index in samsung,pwm-outputs property\n", [...] > + > +static struct dev_pm_ops pwm_samsung_pm_ops = { WARNING: struct dev_pm_ops should normally be const #622: FILE: drivers/pwm/pwm-samsung.c:583: +static struct dev_pm_ops pwm_samsung_pm_ops = { fixed to add const when I applied. > + SET_SYSTEM_SLEEP_PM_OPS(pwm_samsung_suspend, pwm_samsung_resume) > +}; > + Thanks, - Kukjin From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Tue, 25 Jun 2013 00:22:42 +0900 Subject: [PATCH v3 11/18] pwm: Add new pwm-samsung driver In-Reply-To: <2925617.TjWXJcIKRC@flatron> References: <1371766383-29077-1-git-send-email-tomasz.figa@gmail.com> <1371766383-29077-12-git-send-email-tomasz.figa@gmail.com> <2925617.TjWXJcIKRC@flatron> Message-ID: <51C86442.6090406@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/22/13 22:06, Tomasz Figa wrote: > This patch introduces new Samsung PWM driver, which is heavily cleaned, > multiplatform aware and supports DeviceTree based instantiation. > > Since on historical hardware PWM block can be shared with clocksource > driver, a shared spinlock is used to protect access to shared registers, > already exported from the clocksource driver. > > Signed-off-by: Tomasz Figa > --- > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-samsung.c | 601 ++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 602 insertions(+) > create mode 100644 drivers/pwm/pwm-samsung.c > > Changes since v2: > - Replaced __raw_{readl,writel} with {readl,writel}. > - Corrected commit message. > [...] > + of_property_for_each_u32(np, "samsung,pwm-outputs", prop, cur, val) { > + if (val>= SAMSUNG_PWM_NUM) { > + pr_warning("%s: invalid channel index in samsung,pwm-outputs property\n", Just note, checkpatch complains following, so fixed to use pr_warn() when I applied. WARNING: Prefer pr_warn(... to pr_warning(... #471: FILE: drivers/pwm/pwm-samsung.c:432: + pr_warning("%s: invalid channel index in samsung,pwm-outputs property\n", [...] > + > +static struct dev_pm_ops pwm_samsung_pm_ops = { WARNING: struct dev_pm_ops should normally be const #622: FILE: drivers/pwm/pwm-samsung.c:583: +static struct dev_pm_ops pwm_samsung_pm_ops = { fixed to add const when I applied. > + SET_SYSTEM_SLEEP_PM_OPS(pwm_samsung_suspend, pwm_samsung_resume) > +}; > + Thanks, - Kukjin