All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabor Juhos <juhosg@openwrt.org>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	rt2x00 Users List <users@rt2x00.serialmonkey.com>
Subject: Re: [PATCH 2/3] rt2x00: rt2800lib: turn on secondary PAs/LNAs for 3T/3R devices
Date: Mon, 24 Jun 2013 21:00:52 +0200	[thread overview]
Message-ID: <51C89764.8000700@openwrt.org> (raw)
In-Reply-To: <CAGXE3d9_zOt0h6WaWUedXnJu9yucJ=Jtaa8PPacz1-6G2Wf63w@mail.gmail.com>

2013.06.24. 15:00 keltezéssel, Helmut Schaa írta:
> On Sat, Jun 22, 2013 at 5:42 PM, Gabor Juhos <juhosg@openwrt.org> wrote:
>> The secondary PAs/LNAs are turned on only for 2T/2R
>> devices, however these are used for 3T/3R devices as
>> well. Always turn those on if the device uses more
>> than one tx/rx chains.
>>
>> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
>> ---
>>  drivers/net/wireless/rt2x00/rt2800lib.c |    8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
>> index 4072242..f4cd3d8 100644
>> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
>> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
>> @@ -2678,16 +2678,16 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
>>
>>         tx_pin = 0;
>>
>> -       /* Turn on unused PA or LNA when not using 1T or 1R */
>> -       if (rt2x00dev->default_ant.tx_chain_num == 2) {
>> +       if (rt2x00dev->default_ant.tx_chain_num > 1) {
>> +               /* Turn on secondary PAs for 2T adn for 3T devices*/
> 
> Typo adn -> and.
> 
> Otherwise looks good to me.

Thanks, I will send a fixed version.

-Gabor

  reply	other threads:[~2013-06-24 19:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-22 15:42 [PATCH 0/3] rt2x00: rt2800: prepare for three-chain device support Gabor Juhos
2013-06-22 15:42 ` [PATCH 1/3] rt2x00: rt2800: increase EEPROM_SIZE to 512 bytes Gabor Juhos
2013-06-24 13:01   ` Helmut Schaa
2013-06-24 17:32   ` Gertjan van Wingerde
2013-06-22 15:42 ` [PATCH 2/3] rt2x00: rt2800lib: turn on secondary PAs/LNAs for 3T/3R devices Gabor Juhos
2013-06-24 13:00   ` Helmut Schaa
2013-06-24 19:00     ` Gabor Juhos [this message]
2013-06-24 17:33   ` Gertjan van Wingerde
2013-06-22 15:42 ` [PATCH 3/3] rt2x00: rt2800lib: turn on tertiary " Gabor Juhos
2013-06-24 13:02   ` Helmut Schaa
2013-06-24 17:42   ` Gertjan van Wingerde
2013-06-24 19:17     ` Gabor Juhos
2013-06-24 16:00 ` [rt2x00-users] [PATCH 0/3] rt2x00: rt2800: prepare for three-chain device support Stanislaw Gruszka
2013-06-24 19:09   ` Gabor Juhos
2013-06-25 19:18     ` Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C89764.8000700@openwrt.org \
    --to=juhosg@openwrt.org \
    --cc=helmut.schaa@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=users@rt2x00.serialmonkey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.