From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 25 Jun 2013 00:33:46 +0200 (CEST) Received: from mail-pa0-f52.google.com ([209.85.220.52]:49230 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6827575Ab3FXWdpbHIKM (ORCPT ); Tue, 25 Jun 2013 00:33:45 +0200 Received: by mail-pa0-f52.google.com with SMTP id kq13so11689197pab.11 for ; Mon, 24 Jun 2013 15:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=TGqCh+Vo8VIIp0hWB/n+VVAHD4NuvTg1XJMKvUGhoIs=; b=ZO3Xxu/pOC66NyktZpxR4I/40elIPMlnIRV+qA/zvHCWykeYMNzDPwkDMG19kjehkI M7x5mOucdeTj/Msv/0Qc+5hGM7OyOd/I+FvYJXHtgZv8xiZexs0X2LXTC+c0fvIubndM pIPSr+opcA1Q0LWnXFTZFz2GEX/udFPi11hK93/Ei81aFks5hnMa7T++AtN00q6PKE6v hsKyiQSBDGz2AjaJCDPTUaOXZ4oGHm3nJ6TOcqEbNxp151m0G367MKzI1XK1+IHNhqRH tILJASAdEU7Gey61ktXOB96kBBE2HGA6dTiF5G9kcc1qCovkRVXRIOXJ7Q2f92k7ftuk h6ew== X-Received: by 10.68.249.162 with SMTP id yv2mr6411161pbc.153.1372113218581; Mon, 24 Jun 2013 15:33:38 -0700 (PDT) Received: from dl.caveonetworks.com (64.2.3.195.ptr.us.xo.net. [64.2.3.195]) by mx.google.com with ESMTPSA id iq6sm19997181pbc.1.2013.06.24.15.33.36 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 24 Jun 2013 15:33:37 -0700 (PDT) Message-ID: <51C8C940.7080106@gmail.com> Date: Mon, 24 Jun 2013 15:33:36 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Aaro Koskinen CC: Ralf Baechle , linux-mips@linux-mips.org Subject: Re: [PATCH v2 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once References: <1372023524-17333-1-git-send-email-aaro.koskinen@iki.fi> <51C89567.3000108@gmail.com> <20130624220429.GB20703@blackmetal.musicnaut.iki.fi> In-Reply-To: <20130624220429.GB20703@blackmetal.musicnaut.iki.fi> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 37120 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ddaney.cavm@gmail.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 06/24/2013 03:04 PM, Aaro Koskinen wrote: > On Mon, Jun 24, 2013 at 11:52:23AM -0700, David Daney wrote: >> On 06/23/2013 02:38 PM, Aaro Koskinen wrote: >>> When booting a new board for the first time, the console is flooded with >>> "Unknown board" messages. This is not really helpful. Board type is not >>> going to change after the boot, so it's sufficient to print the warning >>> only once. >>> >>> Signed-off-by: Aaro Koskinen >> >> I don't think we need this patch. In 2/2 you add the board type for >> the board you have, so you shouldn't be getting any messages, and >> this is unneeded. >> >> I don't mind spamming people with all the messages, if people see >> these messages, they have bigger problems than too many messages. > > I guess this patch can be dropped, but whoever tries to improve the > support for the next new Octeon board will get annoyed by these same > messages... I would hope that the "next new Octeon board" would have a bootloader that supplies a device tree. That way most of this would never be used, and there would be no messages. David Daney