All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung.kim@lge.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: mingo@kernel.org, hpa@zytor.com, paulus@samba.org,
	eranian@google.com, linux-kernel@vger.kernel.org,
	acme@redhat.com, a.p.zijlstra@chello.nl, namhyung@kernel.org,
	jolsa@redhat.com, dsahern@gmail.com, tglx@linutronix.de,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf sort: Separate out memory-specific sort keys
Date: Tue, 25 Jun 2013 10:00:37 +0900	[thread overview]
Message-ID: <51C8EBB5.3040000@lge.com> (raw)
In-Reply-To: <20130625003010.GU6123@two.firstfloor.org>

Hi Andi,

2013-06-25 AM 9:30, Andi Kleen wrote:
> On Fri, May 31, 2013 at 04:20:20AM -0700, tip-bot for Namhyung Kim wrote:
>> perf sort: Separate out memory-specific sort keys
>>
>> Since they're used only for perf mem, separate out them to a different
>> dimension so that normal user cannot access them by any chance.
>>
>> For global/local weights, I'm not entirely sure to place them into the
>> memory dimension.  But it's the only user at this time.
>
> So I was finally able to test with this patch, but
> I found it completely breaks TSX weight abort profiling.
>
> It uses weight (global/local), but it's not
> running in memory mode.
>
> I'll send a patch to move weight back into
> the common keys.

I'm not sure it should move to the common keys as normal perf session 
won't have those.  I guess you need to set up a couple of TSX-specific 
sort keys like perf mem, if so what about moving the two weights to your 
table?

Thanks,
Namhyung

  reply	other threads:[~2013-06-25  1:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03 12:26 [PATCHSET 00/10] perf tools: Cleanup for sort keys (v2) Namhyung Kim
2013-04-03 12:26 ` [PATCH 01/10] perf sort: Factor out common code in sort_dimension__add() Namhyung Kim
2013-05-31 11:19   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-04-03 12:26 ` [PATCH 02/10] perf sort: Separate out memory-specific sort keys Namhyung Kim
2013-05-31 11:20   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-25  0:30     ` Andi Kleen
2013-06-25  1:00       ` Namhyung Kim [this message]
2013-06-25  1:02         ` Andi Kleen
2013-06-25  1:06           ` Namhyung Kim
2013-04-03 12:26 ` [PATCH 03/10] perf sort: Add 'addr' sort key Namhyung Kim
2013-04-03 17:06   ` Arnaldo Carvalho de Melo
2013-04-04  0:49     ` Namhyung Kim
2013-04-03 12:26 ` [PATCH 04/10] perf sort: Add 'addr_to/from' " Namhyung Kim
2013-04-03 12:26 ` [PATCH 05/10] perf sort: Update documentation for sort keys Namhyung Kim
2013-04-03 12:26 ` [PATCH 06/10] perf hists: Move column length setting code Namhyung Kim
2013-04-03 12:26 ` [PATCH 07/10] perf sort: Cleanup sort__has_sym setting Namhyung Kim
2013-04-03 12:26 ` [PATCH 08/10] perf top: Use sort__has_sym Namhyung Kim
2013-04-03 12:26 ` [PATCH 09/10] perf hist browser: " Namhyung Kim
2013-04-03 17:07   ` Arnaldo Carvalho de Melo
2013-04-04  0:55     ` Namhyung Kim
2013-04-03 12:26 ` [PATCH 10/10] perf sort: Consolidate sort_entry__setup_elide() Namhyung Kim
2013-04-03 17:09   ` Arnaldo Carvalho de Melo
2013-04-04  0:56     ` Namhyung Kim
2013-05-31 11:21   ` [tip:perf/core] " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C8EBB5.3040000@lge.com \
    --to=namhyung.kim@lge.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.