From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: <xen-devel@lists.xen.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/4] xen-blkback: check the number of iovecs before allocating a bios
Date: Tue, 25 Jun 2013 10:03:35 +0200 [thread overview]
Message-ID: <51C94ED7.30006@citrix.com> (raw)
In-Reply-To: <20130624132841.GA21144@phenom.dumpdata.com>
On 24/06/13 15:28, Konrad Rzeszutek Wilk wrote:
> On Sat, Jun 22, 2013 at 09:59:17AM +0200, Roger Pau Monne wrote:
>> With the introduction of indirect segments we can receive requests
>> with a number of segments bigger than the maximum number of allowed
>> iovecs in a bios, so make sure that blkback doesn't try to allocate a
>> bios with more iovecs than BIO_MAX_PAGES
>
> Shouldn't we just gate the feature-indirect-descriptor value to
> take this into account?
>
> What happens if the nseg is > BIO_MAX_PAGES? Do we "lose" the request
> for the remaining segments?
No, we just allocate several bios in order to send the request to the
underlying device.
next prev parent reply other threads:[~2013-06-25 8:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 10:56 [PATCH 0/4] xen-block: bug fixes for indirect-descriptors Roger Pau Monne
2013-06-21 10:56 ` [PATCH 1/4] xen-blkback: workaround compiler bug in gcc 4.1 Roger Pau Monne
2013-06-21 10:56 ` Roger Pau Monne
2013-06-21 10:56 ` [PATCH 2/4] xen-blkfront: set blk_queue_max_hw_sectors correctly Roger Pau Monne
2013-06-21 10:56 ` Roger Pau Monne
2013-06-21 10:56 ` [PATCH 3/4] xen-blkback: check the number of iovecs before allocating a bios Roger Pau Monne
2013-06-21 10:56 ` Roger Pau Monne
2013-06-21 11:46 ` [Xen-devel] " Jan Beulich
2013-06-21 12:02 ` Roger Pau Monné
2013-06-21 12:02 ` [Xen-devel] " Roger Pau Monné
2013-06-21 11:46 ` Jan Beulich
2013-06-22 7:59 ` [PATCH v2 " Roger Pau Monne
2013-06-24 13:28 ` Konrad Rzeszutek Wilk
2013-06-24 13:28 ` Konrad Rzeszutek Wilk
2013-06-25 8:03 ` Roger Pau Monné [this message]
2013-06-25 8:03 ` Roger Pau Monné
2013-06-22 7:59 ` Roger Pau Monne
2013-06-21 10:56 ` [PATCH 4/4] xen-blkfront: increase the default number of indirect segments Roger Pau Monne
2013-06-21 10:56 ` Roger Pau Monne
2013-06-21 11:49 ` [Xen-devel] " Jan Beulich
2013-06-21 11:49 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C94ED7.30006@citrix.com \
--to=roger.pau@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.