All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@lists.ozlabs.org,
	Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] powerpc/hw_brk: Fix clearing of extraneous IRQ
Date: Tue, 25 Jun 2013 14:29:56 +0530	[thread overview]
Message-ID: <51C95C0C.6000905@linux.vnet.ibm.com> (raw)
In-Reply-To: <1372052843-19109-2-git-send-email-mikey@neuling.org>

On 06/24/2013 11:17 AM, Michael Neuling wrote:
> In 9422de3 "powerpc: Hardware breakpoints rewrite to handle non DABR breakpoint
> registers" we changed the way we mark extraneous irqs with this:
> 
> -	info->extraneous_interrupt = !((bp->attr.bp_addr <= dar) &&
> -			(dar - bp->attr.bp_addr < bp->attr.bp_len));
> +	if (!((bp->attr.bp_addr <= dar) &&
> +	      (dar - bp->attr.bp_addr < bp->attr.bp_len)))
> +		info->type |= HW_BRK_TYPE_EXTRANEOUS_IRQ;
> 
> Unfortunately this is bogus as it never clears extraneous IRQ if it's already
> set.
> 
> This correctly clears extraneous IRQ before possibly setting it.
> 
> Signed-off-by: Michael Neuling <mikey@neuling.org>
Reviewed-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>

  reply	other threads:[~2013-06-25  9:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-24  5:47 [PATCH 1/2] powerpc/hw_brk: Fix setting of length for exact mode breakpoints Michael Neuling
2013-06-24  5:47 ` [PATCH 2/2] powerpc/hw_brk: Fix clearing of extraneous IRQ Michael Neuling
2013-06-25  8:59   ` Anshuman Khandual [this message]
2013-06-25  8:48 ` [PATCH 1/2] powerpc/hw_brk: Fix setting of length for exact mode breakpoints Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C95C0C.6000905@linux.vnet.ibm.com \
    --to=khandual@linux.vnet.ibm.com \
    --cc=emachado@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.