From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas KANDAGATLA Subject: Re: [PATCH v5] serial:st-asc: Add ST ASC driver. Date: Tue, 25 Jun 2013 11:14:29 +0100 Message-ID: <51C96D85.7080507@st.com> References: <1372058503-30505-1-git-send-email-srinivas.kandagatla@gmail.com> <20130624233813.GA4108@kroah.com> Reply-To: srinivas.kandagatla-qxv4g6HH51o@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20130624233813.GA4108-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Greg Kroah-Hartman Cc: linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Stephen Gallimore , Stuart Menefy , Grant Likely , Jiri Slaby List-Id: linux-serial@vger.kernel.org T24gMjUvMDYvMTMgMDA6MzgsIEdyZWcgS3JvYWgtSGFydG1hbiB3cm90ZToKPiBPbiBNb24sIEp1 biAyNCwgMjAxMyBhdCAwODoyMTo0M0FNICswMTAwLCBTcmluaXZhcyBLQU5EQUdBVExBIHdyb3Rl Ogo+PiBGcm9tOiBTcmluaXZhcyBLYW5kYWdhdGxhIDxzcmluaXZhcy5rYW5kYWdhdGxhQHN0LmNv bT4KPj4KPj4gVGhpcyBwYXRjaCBhZGRzIHN1cHBvcnQgdG8gQVNDIChhc3luY2hyb25vdXMgc2Vy aWFsIGNvbnRyb2xsZXIpCj4+IGRyaXZlciwgd2hpY2ggaXMgYmFzaWNhbGx5IGEgc3RhbmRhcmQg c2VyaWFsIGRyaXZlci4gVGhpcyBJUCBpcyBjb21tb24KPj4gYWNyb3NzIGFsbCB0aGUgU1QgcGFy dHMgZm9yIHNldHRvcCBib3ggcGxhdGZvcm1zLgo+Pgo+PiBBU0MgaXMgZW1iZWRkZWQgaW4gU1Qg Q09NTVMgSVAgYmxvY2suIEl0IHN1cHBvcnRzIFJ4ICYgVHggZnVuY3Rpb25hbGl0eS4KPj4gSXQg c3VwcG9ydCBhbGwgaW5kdXN0cnkgc3RhbmRhcmQgYmF1ZCByYXRlcy4KPj4KPj4gU2lnbmVkLW9m Zi1ieTogU3Jpbml2YXMgS2FuZGFnYXRsYSA8c3Jpbml2YXMua2FuZGFnYXRsYUBzdC5jb20+Cj4+ IENDOiBTdGVwaGVuIEdhbGxpbW9yZSA8c3RlcGhlbi5nYWxsaW1vcmVAc3QuY29tPgo+PiBDQzog U3R1YXJ0IE1lbmVmeSA8c3R1YXJ0Lm1lbmVmeUBzdC5jb20+Cj4+IENDOiBBcm5kIEJlcmdtYW5u IDxhcm5kQGFybmRiLmRlPgo+PiAtLS0KPj4gSGkgR3JlZywKPj4KPj4gVGhpcyBwYXRjaCBpcyB0 aGUgcGFydCBvZiB0aGUgZHJpdmVyIHN1cHBvcnQgZm9yIFN0aXh4eHggU09Dcy4KPj4gVGhpcyBw YXRjaCB1bmRlcmdvbmUgMy00IGN5Y2xlcyBvZiByZXZpZXcgaW4gYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QuCj4+IEFzIEFybmQgcHJlZmVyZWQgdG8gdGFrZSBvbmx5IFNPQyBzdXBwb3J0IHBhdGNo ZXMgdmlhIGFybS1zb2MsIEFtIAo+PiBzZW5kaW5nIHRoaXMgcGF0Y2ggc2VwZXJhdGVseS4KPj4K Pj4gSWYgaXRzIG5vdCB0b28gbGF0ZSwgY2FuIHlvdSBjb25zaWRlciB0aGlzIHBhdGNoIGZvciAz LjExIHZpYSB0dHkgdHJlZT8KPiAKPiBJIHdvdWxkIGhhdmUgdGFrZW4gaXQsIGJ1dCBpdCBicmVh a3MgdGhlIGJ1aWxkIG9uIG15IG1hY2hpbmU6ClRoYW5rcyBHcmVnLAoKSSBrbm93IHRoZSBwcm9i bGVtLCBzb21lIG9mIHRoZSBtZW1iZXJzIGluIHN0cnVjdCBkZXZpY2UgYXJlIGNvbmRpdGlvbmFs CndpdGggUElOQ1RSTCBzdXBwb3J0LgpJIHRoaW5rIHRoYXQncyBicmVha2luZyBidWlsZCBvbiB5 b3VyIG1hY2hpbmUuCgpJIHdpbGwgZml4IGl0IGFuZCByZXNlbmQgYXMgeW91IHN1Z2dlc3RlZC4K ClRoYW5rcywKc3JpbmkKPiAKPiBkcml2ZXJzL3R0eS9zZXJpYWwvc3QtYXNjLmM6IEluIGZ1bmN0 aW9uIOKAmGFzY19zZXJpYWxfcmVzdW1l4oCZOgo+IGRyaXZlcnMvdHR5L3NlcmlhbC9zdC1hc2Mu Yzo3NzQ6MTU6IGVycm9yOiDigJhzdHJ1Y3QgZGV2aWNl4oCZIGhhcyBubyBtZW1iZXIgbmFtZWQg 4oCYcGluc+KAmQo+IGRyaXZlcnMvdHR5L3NlcmlhbC9zdC1hc2MuYzo3NzU6MzogZXJyb3I6IGlt cGxpY2l0IGRlY2xhcmF0aW9uIG9mIGZ1bmN0aW9uIOKAmHBpbmN0cmxfc2VsZWN0X3N0YXRl4oCZ IFstV2Vycm9yPWltcGxpY2l0LWZ1bmN0aW9uLWRlY2xhcmF0aW9uXQo+IGRyaXZlcnMvdHR5L3Nl cmlhbC9zdC1hc2MuYzo3NzU6Mzc6IGVycm9yOiDigJhzdHJ1Y3QgZGV2aWNl4oCZIGhhcyBubyBt ZW1iZXIgbmFtZWQg4oCYcGluc+KAmQo+IGRyaXZlcnMvdHR5L3NlcmlhbC9zdC1hc2MuYzo3NzY6 MTY6IGVycm9yOiDigJhzdHJ1Y3QgZGV2aWNl4oCZIGhhcyBubyBtZW1iZXIgbmFtZWQg4oCYcGlu c+KAmQo+IAo+IFBsZWFzZSB0ZXN0IHlvdXIgcGF0Y2hlcyBvdXQgb24gYSAibm9ybWFsIiBMaW51 eCBzeXN0ZW0uCgo+IAo+IFBsZWFzZSBmZWVsIGZyZWUgdG8gcmVzZW5kIHRoaXMgYWZ0ZXIgMy4x MS1yYzEgaXMgb3V0LCBmb3IgaW5jbHVzaW9uIGluCj4gMy4xMiwgYWZ0ZXIgeW91IGhhdmUgZml4 ZWQgdGhlIGJ1aWxkIHByb2JsZW1zLgo+IAo+IGdyZWcgay1oCj4gCj4gCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZpY2V0cmVlLWRpc2N1c3MgbWFp bGluZyBsaXN0CmRldmljZXRyZWUtZGlzY3Vzc0BsaXN0cy5vemxhYnMub3JnCmh0dHBzOi8vbGlz dHMub3psYWJzLm9yZy9saXN0aW5mby9kZXZpY2V0cmVlLWRpc2N1c3MK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752860Ab3FYKTU (ORCPT ); Tue, 25 Jun 2013 06:19:20 -0400 Received: from eu1sys200aog108.obsmtp.com ([207.126.144.125]:43817 "EHLO eu1sys200aog108.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752685Ab3FYKTP (ORCPT ); Tue, 25 Jun 2013 06:19:15 -0400 Message-ID: <51C96D85.7080507@st.com> Date: Tue, 25 Jun 2013 11:14:29 +0100 From: Srinivas KANDAGATLA Reply-To: srinivas.kandagatla@st.com Organization: STMicroelectronics User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Greg Kroah-Hartman Cc: Grant Likely , Rob Herring , Rob Landley , Jiri Slaby , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Stephen Gallimore , Stuart Menefy , Arnd Bergmann Subject: Re: [PATCH v5] serial:st-asc: Add ST ASC driver. References: <1372058503-30505-1-git-send-email-srinivas.kandagatla@gmail.com> <20130624233813.GA4108@kroah.com> In-Reply-To: <20130624233813.GA4108@kroah.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/06/13 00:38, Greg Kroah-Hartman wrote: > On Mon, Jun 24, 2013 at 08:21:43AM +0100, Srinivas KANDAGATLA wrote: >> From: Srinivas Kandagatla >> >> This patch adds support to ASC (asynchronous serial controller) >> driver, which is basically a standard serial driver. This IP is common >> across all the ST parts for settop box platforms. >> >> ASC is embedded in ST COMMS IP block. It supports Rx & Tx functionality. >> It support all industry standard baud rates. >> >> Signed-off-by: Srinivas Kandagatla >> CC: Stephen Gallimore >> CC: Stuart Menefy >> CC: Arnd Bergmann >> --- >> Hi Greg, >> >> This patch is the part of the driver support for Stixxxx SOCs. >> This patch undergone 3-4 cycles of review in arm-kernel mailing list. >> As Arnd prefered to take only SOC support patches via arm-soc, Am >> sending this patch seperately. >> >> If its not too late, can you consider this patch for 3.11 via tty tree? > > I would have taken it, but it breaks the build on my machine: Thanks Greg, I know the problem, some of the members in struct device are conditional with PINCTRL support. I think that's breaking build on your machine. I will fix it and resend as you suggested. Thanks, srini > > drivers/tty/serial/st-asc.c: In function ‘asc_serial_resume’: > drivers/tty/serial/st-asc.c:774:15: error: ‘struct device’ has no member named ‘pins’ > drivers/tty/serial/st-asc.c:775:3: error: implicit declaration of function ‘pinctrl_select_state’ [-Werror=implicit-function-declaration] > drivers/tty/serial/st-asc.c:775:37: error: ‘struct device’ has no member named ‘pins’ > drivers/tty/serial/st-asc.c:776:16: error: ‘struct device’ has no member named ‘pins’ > > Please test your patches out on a "normal" Linux system. > > Please feel free to resend this after 3.11-rc1 is out, for inclusion in > 3.12, after you have fixed the build problems. > > greg k-h > >