From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrRki-0005he-JU for qemu-devel@nongnu.org; Tue, 25 Jun 2013 07:49:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrRkg-0005n8-8w for qemu-devel@nongnu.org; Tue, 25 Jun 2013 07:49:40 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34014 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrRkf-0005mX-Vk for qemu-devel@nongnu.org; Tue, 25 Jun 2013 07:49:38 -0400 Message-ID: <51C983CE.6000506@suse.de> Date: Tue, 25 Jun 2013 13:49:34 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1372156544-31712-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1372156544-31712-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] linux-user: Move cpu_clone_regs() and cpu_set_tls() into linux-user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Riku Voipio Cc: Jia Liu , patches@linaro.org, Alexander Graf , qemu-devel@nongnu.org, Blue Swirl , "Edgar E. Iglesias" , Guan Xuetao , Aurelien Jarno , Richard Henderson Am 25.06.2013 12:35, schrieb Peter Maydell: > The functions cpu_clone_regs() and cpu_set_tls() are not purely CPU > related -- they are specific to the TLS ABI for a a particular OS. > Move them into the linux-user/ tree where they belong. >=20 > Signed-off-by: Peter Maydell > --- > The recent bsd-user patch series reminded me what a mess the > current NPTL/threading status of linux-user is. I have some things > in mind to clean it up (and maybe even actually get all targets > up to having NPTL enabled, since it's mostly just implementing > the two functions being moved here for x86, sparc, openrisc. >=20 > Andreas, I hope this doesn't cut across anything you were > planning for your QOM tree. This looks along the lines of what we had been discussing - I hadn't worked on that yet, unsure where to put things. Since it is touching on each cpu.h, I would prefer to take it through qom-cpu queue if Riku doesn't object. Regards, Andreas >=20 > NB: copyright/license headers for the new header files are > taken from the cpu.h that the functions came from. In a couple > of cases where cpu.h had no license header I used the one from > the corresponding translate.c. >=20 > linux-user/alpha/target_cpu.h | 36 ++++++++++++++++++++++++++++= +++ > linux-user/arm/target_cpu.h | 35 ++++++++++++++++++++++++++++= ++ > linux-user/cris/target_cpu.h | 36 ++++++++++++++++++++++++++++= +++ > linux-user/i386/target_cpu.h | 10 +++++++++ > linux-user/m68k/target_cpu.h | 34 ++++++++++++++++++++++++++++= ++ > linux-user/microblaze/target_cpu.h | 35 ++++++++++++++++++++++++++++= ++ > linux-user/mips/target_cpu.h | 36 ++++++++++++++++++++++++++++= +++ > linux-user/mips64/target_cpu.h | 1 + > linux-user/openrisc/target_cpu.h | 10 +++++++++ > linux-user/ppc/target_cpu.h | 41 ++++++++++++++++++++++++++++= ++++++++ > linux-user/qemu.h | 1 + > linux-user/s390x/target_cpu.h | 39 ++++++++++++++++++++++++++++= ++++++ > linux-user/sh4/target_cpu.h | 35 ++++++++++++++++++++++++++++= ++ > linux-user/sparc/target_cpu.h | 36 ++++++++++++++++++++++++++++= +++ > linux-user/sparc64/target_cpu.h | 1 + > linux-user/unicore32/target_cpu.h | 27 ++++++++++++++++++++++++ > linux-user/x86_64/target_cpu.h | 1 + > target-alpha/cpu.h | 16 -------------- > target-arm/cpu.h | 14 ------------ > target-cris/cpu.h | 14 ------------ > target-m68k/cpu.h | 9 -------- > target-microblaze/cpu.h | 14 ------------ > target-mips/cpu.h | 13 ------------ > target-ppc/cpu.h | 20 ------------------ > target-s390x/cpu.h | 16 -------------- > target-sh4/cpu.h | 14 ------------ > target-sparc/cpu.h | 12 ----------- > target-unicore32/cpu.h | 13 ------------ > 28 files changed, 414 insertions(+), 155 deletions(-) > create mode 100644 linux-user/alpha/target_cpu.h > create mode 100644 linux-user/arm/target_cpu.h > create mode 100644 linux-user/cris/target_cpu.h > create mode 100644 linux-user/i386/target_cpu.h > create mode 100644 linux-user/m68k/target_cpu.h > create mode 100644 linux-user/microblaze/target_cpu.h > create mode 100644 linux-user/mips/target_cpu.h > create mode 100644 linux-user/mips64/target_cpu.h > create mode 100644 linux-user/openrisc/target_cpu.h > create mode 100644 linux-user/ppc/target_cpu.h > create mode 100644 linux-user/s390x/target_cpu.h > create mode 100644 linux-user/sh4/target_cpu.h > create mode 100644 linux-user/sparc/target_cpu.h > create mode 100644 linux-user/sparc64/target_cpu.h > create mode 100644 linux-user/unicore32/target_cpu.h > create mode 100644 linux-user/x86_64/target_cpu.h [snip] --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg