Re: [Qemu-devel] [PATCH v11 04/15] rdma: export throughput w/ MigrationStats QMP

["Michael R. Hines" <mrhines@linux.vnet.ibm.com>]

On 06/25/2013 05:27 AM, Juan Quintela wrote:
> mrhines@linux.vnet.ibm.com wrote:
>> From: "Michael R. Hines" <mrhines@us.ibm.com>
>>
>> This exposes throughput (in megabits/sec) through QMP.
>>
>> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>> Reviewed-by: Chegu Vinod <chegu_vinod@hp.com>
>> Tested-by: Chegu Vinod <chegu_vinod@hp.com>
>> Tested-by: Michael R. Hines <mrhines@us.ibm.com>
>> Signed-off-by: Michael R. Hines <mrhines@us.ibm.com>
>> @@ -154,8 +154,10 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
>>   
>>       if (info->has_status) {
>>           monitor_printf(mon, "Migration status: %s\n", info->status);
>> -        monitor_printf(mon, "total time: %" PRIu64 " milliseconds\n",
>> -                       info->total_time);
>> +        if (info->has_total_time) {
>> +            monitor_printf(mon, "total time: %" PRIu64 " milliseconds\n",
>> +                           info->total_time);
>> +        }
>>           if (info->has_expected_downtime) {
>>               monitor_printf(mon, "expected downtime: %" PRIu64 " milliseconds\n",
>>                              info->expected_downtime);
> This chunk don't belong to this patch.
>
> for the rest:
>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
>

Acknowledged - will drop the hunk in the next version.

- Michael