From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: imain@redhat.com, Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block: add drive_backup HMP command
Date: Tue, 25 Jun 2013 15:49:43 +0200 [thread overview]
Message-ID: <51C99FF7.5060705@redhat.com> (raw)
In-Reply-To: <20130625132638.GL3539@dhcp-200-207.str.redhat.com>
Il 25/06/2013 15:26, Kevin Wolf ha scritto:
>> > + if (!full) {
>> > + error_setg(&errp, "-f is not yet implemented");
>> > + hmp_handle_error(mon, &errp);
>> > + return;
>> > + }
> Then why make it a valid option and confuse users in the help text by
> describing options that don't really exist?
>
Because otherwise we're stuck with a meaning of the flag that is
different between drive-mirror and block-backup.
Paolo
next prev parent reply other threads:[~2013-06-25 13:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 12:23 [Qemu-devel] [PATCH] block: add drive_backup HMP command Stefan Hajnoczi
2013-06-25 13:26 ` Kevin Wolf
2013-06-25 13:49 ` Paolo Bonzini [this message]
2013-06-25 14:06 ` Kevin Wolf
2013-06-25 14:36 ` Paolo Bonzini
2013-06-25 14:43 ` Kevin Wolf
2013-06-25 17:40 ` Ian Main
2013-06-26 7:44 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C99FF7.5060705@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=imain@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.