Re: [PATCH 07/23] video: da8xx-fb: pix clk and clk div handling cleanup

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]

On 25/06/13 17:22, Darren Etheridge wrote:
> From: Afzal Mohammed <afzal@ti.com>
> 
> Use the new modedb field to store pix clk. Reorganize existing clock
> divider functions with names now corresponding to what they do, add
> common function prefix.
> 
> Fix existing panel modedb pixclock to be in ps instead of Hz. This
> needed a change in the way clock divider is calculated. As modedb
> pixclock information is now in ps, override on "var" pixclock over
> modedb to var conversion is removed.
> 
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> Signed-off-by: Darren Etheridge <detheridge@ti.com>
> ---
>  drivers/video/da8xx-fb.c |   48 +++++++++++++++++----------------------------
>  1 files changed, 18 insertions(+), 30 deletions(-)
> 
> diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
> index f1d88ac..7f08644 100644
> --- a/drivers/video/da8xx-fb.c
> +++ b/drivers/video/da8xx-fb.c
> @@ -160,7 +160,6 @@ struct da8xx_fb_par {
>  	struct clk *lcdc_clk;
>  	int irq;
>  	unsigned int palette_sz;
> -	unsigned int pxl_clk;
>  	int blank;
>  	wait_queue_head_t	vsync_wait;
>  	int			vsync_flag;
> @@ -201,7 +200,7 @@ static struct fb_videomode known_lcd_panels[] = {
>  		.name           = "Sharp_LCD035Q3DG01",
>  		.xres           = 320,
>  		.yres           = 240,
> -		.pixclock       = 4608000,
> +		.pixclock       = 217014,

Maybe it'd be better to use a macro here and convert from Hz to ps. The
panel specs always (afaik) report the pixel clock in Hz, and it also
makes the units clear to the reader.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]