All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-devel <qemu-devel@nongnu.org>,
	Alexander Graf <agraf@suse.de>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH 0/3] spapr: Fix remaining compiler warnings
Date: Wed, 26 Jun 2013 10:14:57 +0200	[thread overview]
Message-ID: <51CAA301.2070703@redhat.com> (raw)
In-Reply-To: <1372096130-24994-1-git-send-email-sw@weilnetz.de>

Il 24/06/2013 19:48, Stefan Weil ha scritto:
> Hi Alex,
> 
> this mini series fixes the remaining compiler warnings in
> my w32/w64 cross build environment on Debian wheezy.
> 
> [PATCH 1/3] spapr: Use named enum for function remove_hpte
> [PATCH 2/3] spapr: Fix compiler warning for some versions of gcc
> [PATCH 3/3] spapr: Fix compiler warning for some versions of gcc
> 
> The modifications are nearly trivial, but this time it would
> be better if you could apply them to your patch queue.

I think these patches are a bit backwards.

The right fix is just to use abort() instead of assert(0).

Paolo

      parent reply	other threads:[~2013-06-26  8:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-24 17:48 [Qemu-devel] [PATCH 0/3] spapr: Fix remaining compiler warnings Stefan Weil
2013-06-24 17:48 ` [Qemu-devel] [PATCH 1/3] spapr: Use named enum for function remove_hpte Stefan Weil
2013-07-02 12:45   ` Alexander Graf
2013-06-24 17:48 ` [Qemu-devel] [PATCH 2/3] spapr: Fix compiler warning for some versions of gcc (h_remove) Stefan Weil
2013-06-24 20:27   ` Paolo Bonzini
2013-06-24 20:35     ` Stefan Weil
2013-06-24 21:07       ` Paolo Bonzini
2013-06-24 17:48 ` [Qemu-devel] [PATCH 3/3] spapr: Fix compiler warning for some versions of gcc (spapr_io_read) Stefan Weil
2013-07-02 12:45   ` Alexander Graf
2013-07-02 20:22     ` Stefan Weil
2013-07-02 20:25       ` Alexander Graf
2013-06-26  8:14 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51CAA301.2070703@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.