Re: [PATCH 18/23] video: da8xx-fb: invoke platform callback safely

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]

On 25/06/13 17:22, Darren Etheridge wrote:
> From: Afzal Mohammed <afzal@ti.com>
> 
> Ensure that platform data is present before checking whether platform
> callback is present (the one used to control backlight). So far this
> was not an issue as driver was purely non-DT triggered, but now DT
> support has been added.
> 
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> Signed-off-by: Darren Etheridge <detheridge@ti.com>
> ---
>  drivers/video/da8xx-fb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
> index 08ee8eb..0beed20 100644
> --- a/drivers/video/da8xx-fb.c
> +++ b/drivers/video/da8xx-fb.c
> @@ -1347,7 +1347,7 @@ static int fb_probe(struct platform_device *device)
>  	par->dev = &device->dev;
>  	par->lcdc_clk = fb_clk;
>  	par->lcd_fck_rate = clk_get_rate(fb_clk);
> -	if (fb_pdata->panel_power_ctrl) {
> +	if (fb_pdata && fb_pdata->panel_power_ctrl) {
>  		par->panel_power_ctrl = fb_pdata->panel_power_ctrl;
>  		par->panel_power_ctrl(1);
>  	}
> 

This patch (and others too in case there are other "fix something to
make DT possible" patches) should be in the series before adding the
actual DT support.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]