From mboxrd@z Thu Jan 1 00:00:00 1970 From: dirk.behme@de.bosch.com (Dirk Behme) Date: Wed, 26 Jun 2013 14:28:58 +0200 Subject: [PATCH] ARM: smp_twd: twd_update_frequency need be run on all online CPUs In-Reply-To: References: <1371079180-22344-1-git-send-email-r64343@freescale.com> <20130617073120.GA4537@S2101-09.ap.freescale.net> Message-ID: <51CADE8A.7010008@de.bosch.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 17.06.2013 10:11, Liu Hui-R64343 wrote: >> -----Original Message----- >> From: Shawn Guo [mailto:shawn.guo at linaro.org] >> Sent: Monday, June 17, 2013 3:31 PM >> To: Liu Hui-R64343 >> Cc: linux-arm-kernel at lists.infradead.org >> Subject: Re: [PATCH] ARM: smp_twd: twd_update_frequency need be run on >> all online CPUs >> >> On Thu, Jun 13, 2013 at 07:19:40AM +0800, Jason Liu wrote: >>> When the local timer freq changed, the twd_update_frequency function >>> should be run all the CPUs include itself, otherwise, the twd freq >>> will not get updated and the local timer will not run correcttly. >>> >>> smp_call_function will run functions on all other CPUs, but not >>> include himself, this is not correct,use on_each_cpu instead to fix >> this issue. >>> >>> Signed-off-by: Jason Liu >>> Cc: Russell King >>> Cc: Linus Walleij >>> Cc: Rob Herring >>> Cc: Shawn Guo >> >> Acked-by: Shawn Guo > > Thanks Shawn. > >> >> BTW, is there anything wrong with your mailer (git send-email command >> line)? I do not see people you put on Cc tag here show up in Cc of the >> email. And that might the be reason why people are not responding so >> far. > > Yes, there is one issue in my script and get fixed. I will put the patch > Into Russell's patch tracking system after Mike and Russell reviewed it > And also Cc stable kernel as Linus W. said. Any news on this? Thanks Dirk >> Shawn >> >>> Cc: Arnd Bergmann >>> Cc: stable at vger.kernel.org >>> --- >>> arch/arm/kernel/smp_twd.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c >>> index 90525d9..f6fd1d4 100644 >>> --- a/arch/arm/kernel/smp_twd.c >>> +++ b/arch/arm/kernel/smp_twd.c >>> @@ -120,7 +120,7 @@ static int twd_rate_change(struct notifier_block >> *nb, >>> * changing cpu. >>> */ >>> if (flags == POST_RATE_CHANGE) >>> - smp_call_function(twd_update_frequency, >>> + on_each_cpu(twd_update_frequency, >>> (void *)&cnd->new_rate, 1); >>> >>> return NOTIFY_OK; >>> -- >>> 1.7.10.4