From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 26 Jun 2013 17:35:17 +0200 (CEST) Received: from multi.imgtec.com ([194.200.65.239]:18370 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6823098Ab3FZPfMgZZMn (ORCPT ); Wed, 26 Jun 2013 17:35:12 +0200 Message-ID: <51CB0A20.30803@imgtec.com> Date: Wed, 26 Jun 2013 10:34:56 -0500 From: "Steven J. Hill" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Ralf Baechle CC: , Leonid Yegoshin , Florian Fainelli Subject: Re: [PATCH v2] Revert "MIPS: make CAC_ADDR and UNCAC_ADDR account for PHYS_OFFSET" References: <1371742590-10138-1-git-send-email-Steven.Hill@imgtec.com> <20130626145234.GB7171@linux-mips.org> In-Reply-To: <20130626145234.GB7171@linux-mips.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.159.60] X-SEF-Processed: 7_3_0_01192__2013_06_26_16_35_07 Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 37136 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Steven.Hill@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 06/26/2013 09:52 AM, Ralf Baechle wrote: > On Thu, Jun 20, 2013 at 10:36:30AM -0500, Steven J. Hill wrote: > >> From: Leonid Yegoshin >> >> This reverts commit 3f4579252aa166641861a64f1c2883365ca126c2. It is >> invalid because the macros CAC_ADDR and UNCAC_ADDR have a kernel >> virtual address as an argument and also returns a kernel virtual >> address. Using and physical address PHYS_OFFSET is blatantly wrong >> for a macro common to multiple platforms. > > While the patch itself is looking sane at a glance, I'm wondering if this > is fixing any actual bug or is just the result of a code review? > The new Aptiv cores are no longer bound by KSEGxxx address spaces. This means that the values for KUSEG, KSEG0, KSEG1, KSEG2 cannot be assumed to be static anymore, and some macros need to be changed accordingly. -Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from multi.imgtec.com ([194.200.65.239]:18370 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6823098Ab3FZPfMgZZMn (ORCPT ); Wed, 26 Jun 2013 17:35:12 +0200 Message-ID: <51CB0A20.30803@imgtec.com> Date: Wed, 26 Jun 2013 10:34:56 -0500 From: "Steven J. Hill" MIME-Version: 1.0 Subject: Re: [PATCH v2] Revert "MIPS: make CAC_ADDR and UNCAC_ADDR account for PHYS_OFFSET" References: <1371742590-10138-1-git-send-email-Steven.Hill@imgtec.com> <20130626145234.GB7171@linux-mips.org> In-Reply-To: <20130626145234.GB7171@linux-mips.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Ralf Baechle Cc: linux-mips@linux-mips.org, Leonid Yegoshin , Florian Fainelli Message-ID: <20130626153456.bYhuZiqyLaLyb4dW8g3oRv9bgh4NaU7LqCS2k8EeJC0@z> On 06/26/2013 09:52 AM, Ralf Baechle wrote: > On Thu, Jun 20, 2013 at 10:36:30AM -0500, Steven J. Hill wrote: > >> From: Leonid Yegoshin >> >> This reverts commit 3f4579252aa166641861a64f1c2883365ca126c2. It is >> invalid because the macros CAC_ADDR and UNCAC_ADDR have a kernel >> virtual address as an argument and also returns a kernel virtual >> address. Using and physical address PHYS_OFFSET is blatantly wrong >> for a macro common to multiple platforms. > > While the patch itself is looking sane at a glance, I'm wondering if this > is fixing any actual bug or is just the result of a code review? > The new Aptiv cores are no longer bound by KSEGxxx address spaces. This means that the values for KUSEG, KSEG0, KSEG1, KSEG2 cannot be assumed to be static anymore, and some macros need to be changed accordingly. -Steve