From: Ian Murray <murrayie@yahoo.co.uk>
To: Ian Murray <murrayie@yahoo.co.uk>
Cc: George.Dunlap@eu.citrix.com, Ian.Campbell@citrix.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH] [Reminder] Xendomains was not correctly suspending domains when a STOP was issued.
Date: Wed, 26 Jun 2013 22:41:08 +0100 [thread overview]
Message-ID: <51CB5FF4.4020406@yahoo.co.uk> (raw)
In-Reply-To: <1371904691-9842-1-git-send-email-murrayie@yahoo.co.uk>
I was under the impression that this in line for 4.3 RC6 but as of yet,
I am not seeing it in git. Maybe it's queued, in which case ignore this
or if it's been forgotten, then please don't ignore this. :)
Thanks,
Ian
On 22/06/13 13:38, Ian Murray wrote:
> The regex was not selecting the { when parsing JSON output of xl list -l.
> It was also not selecting (domain when parsing xl list -l when SXP selected.
>
> Pefixed { with 4 spaces, and removed an extra ( before domain in the regex
> string
>
> Added quotes around the grep strings so the spaces inserted into the string
> didn't not break the grepping.
>
> This has now been tested against 4.3RC5
>
> Signed-off-by: Ian Murray <murrayie@yahoo.co.uk>
> ---
> tools/hotplug/Linux/init.d/xendomains | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tools/hotplug/Linux/init.d/xendomains b/tools/hotplug/Linux/init.d/xendomains
> index 730541e..38371af 100644
> --- a/tools/hotplug/Linux/init.d/xendomains
> +++ b/tools/hotplug/Linux/init.d/xendomains
> @@ -206,7 +206,7 @@ rdnames()
> done
> }
>
> -LIST_GREP='((domain\|(domid\|(name\|^{$\|"name":\|"domid":'
> +LIST_GREP='(domain\|(domid\|(name\|^ {$\|"name":\|"domid":'
> parseln()
> {
> if [[ "$1" =~ '(domain' ]] || [[ "$1" = "{" ]]; then
> @@ -237,7 +237,7 @@ is_running()
> RC=0
> ;;
> esac
> - done < <($CMD list -l | grep $LIST_GREP)
> + done < <($CMD list -l | grep "$LIST_GREP")
> return $RC
> }
>
> @@ -319,7 +319,7 @@ all_zombies()
> if test "$state" != "-b---d" -a "$state" != "-----d"; then
> return 1;
> fi
> - done < <($CMD list -l | grep $LIST_GREP)
> + done < <($CMD list -l | grep "$LIST_GREP")
> return 0
> }
>
> @@ -450,7 +450,7 @@ stop()
> fi
> kill $WDOG_PID >/dev/null 2>&1
> fi
> - done < <($CMD list -l | grep $LIST_GREP)
> + done < <($CMD list -l | grep "$LIST_GREP")
>
> # NB. this shuts down ALL Xen domains (politely), not just the ones in
> # AUTODIR/*
> @@ -487,7 +487,7 @@ check_domain_up()
> return 0
> ;;
> esac
> - done < <($CMD list -l | grep $LIST_GREP)
> + done < <($CMD list -l | grep "$LIST_GREP")
> return 1
> }
>
next prev parent reply other threads:[~2013-06-26 21:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-22 12:38 [PATCH] Xendomains was not correctly suspending domains when a STOP was issued Ian Murray
2013-06-24 10:50 ` George Dunlap
2013-06-24 14:36 ` Ian Murray
2013-06-26 21:41 ` Ian Murray [this message]
2013-06-27 8:07 ` [PATCH] [Reminder] " Ian Campbell
2013-06-27 11:32 ` [PATCH] " Ian Campbell
2013-06-27 11:51 ` Ian Murray
2013-06-27 11:59 ` Ian Campbell
2013-06-27 12:15 ` Ian Murray
2013-06-27 12:19 ` Ian Campbell
2013-06-27 12:30 ` Ian Murray
2013-06-27 13:06 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CB5FF4.4020406@yahoo.co.uk \
--to=murrayie@yahoo.co.uk \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.